1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tst_qocsp: improve code coverage

Browse Source 
By simply extending the basic test to trigger qHash, isEqual and
a bunch of getters.

Change-Id: Ib1d88fc6d2ad623743cea77ac286ae6ac819dfd1
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
(cherry picked from commit 1d7189f5b3eb03e7c71fb31e2bd491d0e5a535e4)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Timur Pocheptsov 2020-11-19 15:26:08 +01:00 committed by Qt Cherry-pick Bot
parent 72c31006a9
commit ab3f3d5c4d
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tests/auto/network/ssl/qocsp/tst_qocsp.cpp
View File

@ -490,9 +490,9 @@ void tst_QOcsp::connectSelfSigned()
{ {
// Now the server will send a valid 'status: good' response. // Now the server will send a valid 'status: good' response.
OcspServer server(subjectChain, privateKey); OcspServer server(subjectChain, privateKey);
const QByteArray response(goodResponse(subjectChain, responderChain, privateKey)); const QByteArray responseData(goodResponse(subjectChain, responderChain, privateKey));
QVERIFY(response.size()); QVERIFY(responseData.size());
server.configureResponse(response); server.configureResponse(responseData);
QVERIFY(server.listen()); QVERIFY(server.listen());
QSslSocket clientSocket; QSslSocket clientSocket;
@ -501,6 +501,19 @@ void tst_QOcsp::connectSelfSigned()
loop.enterLoopMSecs(handshakeTimeoutMS); loop.enterLoopMSecs(handshakeTimeoutMS);
QVERIFY_HANDSHAKE_WITHOUT_ERRORS(clientSocket); QVERIFY_HANDSHAKE_WITHOUT_ERRORS(clientSocket);
const auto responses = clientSocket.ocspResponses();
QCOMPARE(responses.size(), 1);
const auto &response = responses.at(0);
QVERIFY(response != QOcspResponse());
const auto copy = response;
QCOMPARE(copy, response);
QVERIFY(qHash(response, 0) != 0);
QCOMPARE(response.revocationReason(), QOcspRevocationReason::None);
QCOMPARE(response.certificateStatus(), QOcspCertificateStatus::Good);
QCOMPARE(response.subject(), clientSocket.peerCertificate());
QCOMPARE(response.responder(), clientSocket.peerCertificate());
} }
} }