Move text-related code out of corelib/tools/ to corelib/text/

This includes byte array, string, char, unicode, locale, collation and
regular expressions.

Change-Id: I8b125fa52c8c513eb57a0f1298b91910e5a0d786
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>

qmake/Makefile.unix

@@ -105,24 +105,24 @@ DEPEND_SRC = \
 	   $(SOURCE_PATH)/src/corelib/serialization/qtextstream.cpp \
 	   $(SOURCE_PATH)/src/corelib/serialization/qxmlstream.cpp \
 	   $(SOURCE_PATH)/src/corelib/serialization/qxmlutils.cpp \
+	   $(SOURCE_PATH)/src/corelib/text/qbytearray.cpp\
+	   $(SOURCE_PATH)/src/corelib/text/qbytearraymatcher.cpp \
+	   $(SOURCE_PATH)/src/corelib/text/qlocale.cpp \
+	   $(SOURCE_PATH)/src/corelib/text/qlocale_tools.cpp \
+	   $(SOURCE_PATH)/src/corelib/text/qregexp.cpp \
+	   $(SOURCE_PATH)/src/corelib/text/qstringbuilder.cpp \
+	   $(SOURCE_PATH)/src/corelib/text/qstring.cpp \
+	   $(SOURCE_PATH)/src/corelib/text/qstringlist.cpp \
+	   $(SOURCE_PATH)/src/corelib/text/qvsnprintf.cpp \
 	   $(SOURCE_PATH)/src/corelib/time/qdatetime.cpp \
 	   $(SOURCE_PATH)/src/corelib/tools/qarraydata.cpp \
 	   $(SOURCE_PATH)/src/corelib/tools/qbitarray.cpp \
-	   $(SOURCE_PATH)/src/corelib/tools/qbytearray.cpp\
-	   $(SOURCE_PATH)/src/corelib/tools/qbytearraymatcher.cpp \
 	   $(SOURCE_PATH)/src/corelib/tools/qcryptographichash.cpp \
 	   $(SOURCE_PATH)/src/corelib/tools/qhash.cpp \
 	   $(SOURCE_PATH)/src/corelib/tools/qlist.cpp \
-	   $(SOURCE_PATH)/src/corelib/tools/qlocale.cpp \
-	   $(SOURCE_PATH)/src/corelib/tools/qlocale_tools.cpp \
 	   $(SOURCE_PATH)/src/corelib/tools/qmap.cpp \
-	   $(SOURCE_PATH)/src/corelib/tools/qregexp.cpp \
 	   $(SOURCE_PATH)/src/corelib/tools/qringbuffer.cpp \
-	   $(SOURCE_PATH)/src/corelib/tools/qstringbuilder.cpp \
-	   $(SOURCE_PATH)/src/corelib/tools/qstring.cpp \
-	   $(SOURCE_PATH)/src/corelib/tools/qstringlist.cpp \
 	   $(SOURCE_PATH)/src/corelib/tools/qversionnumber.cpp \
-	   $(SOURCE_PATH)/src/corelib/tools/qvsnprintf.cpp \
 	   $(QTSRCS) $(QTSRCS2)
 # QTSRCS and QTSRCS2 come from Makefile.unix.* (concatenated with this
 # by configure); QTSRCS2 may include *.mm entries on macOS.
@@ -302,13 +302,13 @@ qglobal.o: $(SOURCE_PATH)/src/corelib/global/qglobal.cpp
 qarraydata.o: $(SOURCE_PATH)/src/corelib/tools/qarraydata.cpp
 	$(CXX) -c -o $@ $(CXXFLAGS) $<
 
-qbytearray.o: $(SOURCE_PATH)/src/corelib/tools/qbytearray.cpp
+qbytearray.o: $(SOURCE_PATH)/src/corelib/text/qbytearray.cpp
 	$(CXX) -c -o $@ $(CXXFLAGS) $<
 
-qvsnprintf.o: $(SOURCE_PATH)/src/corelib/tools/qvsnprintf.cpp
+qvsnprintf.o: $(SOURCE_PATH)/src/corelib/text/qvsnprintf.cpp
 	$(CXX) -c -o $@ $(CXXFLAGS) $<
 
-qbytearraymatcher.o: $(SOURCE_PATH)/src/corelib/tools/qbytearraymatcher.cpp
+qbytearraymatcher.o: $(SOURCE_PATH)/src/corelib/text/qbytearraymatcher.cpp
 	$(CXX) -c -o $@ $(CXXFLAGS) $<
 
 qmetatype.o: $(SOURCE_PATH)/src/corelib/kernel/qmetatype.cpp
@@ -338,22 +338,22 @@ qcore_foundation.o: $(SOURCE_PATH)/src/corelib/kernel/qcore_foundation.mm
 qutfcodec.o: $(SOURCE_PATH)/src/corelib/codecs/qutfcodec.cpp
 	$(CXX) -c -o $@ $(CXXFLAGS) $<
 
-qstring.o: $(SOURCE_PATH)/src/corelib/tools/qstring.cpp
+qstring.o: $(SOURCE_PATH)/src/corelib/text/qstring.cpp
 	$(CXX) -c -o $@ $(CXXFLAGS) $<
 
-qstringbuilder.o: $(SOURCE_PATH)/src/corelib/tools/qstringbuilder.cpp
+qstringbuilder.o: $(SOURCE_PATH)/src/corelib/text/qstringbuilder.cpp
 	$(CXX) -c -o $@ $(CXXFLAGS) $<
 
-qlocale.o: $(SOURCE_PATH)/src/corelib/tools/qlocale.cpp
+qlocale.o: $(SOURCE_PATH)/src/corelib/text/qlocale.cpp
 	$(CXX) -c -o $@ $(CXXFLAGS) $<
 
-qlocale_tools.o: $(SOURCE_PATH)/src/corelib/tools/qlocale_tools.cpp
+qlocale_tools.o: $(SOURCE_PATH)/src/corelib/text/qlocale_tools.cpp
 	$(CXX) -c -o $@ $(CXXFLAGS) $<
 
-qlocale_unix.o: $(SOURCE_PATH)/src/corelib/tools/qlocale_unix.cpp
+qlocale_unix.o: $(SOURCE_PATH)/src/corelib/text/qlocale_unix.cpp
 	$(CXX) -c -o $@ $(CXXFLAGS) $<
 
-qlocale_win.o: $(SOURCE_PATH)/src/corelib/tools/qlocale_win.cpp
+qlocale_win.o: $(SOURCE_PATH)/src/corelib/text/qlocale_win.cpp
 	$(CXX) -c -o $@ $(CXXFLAGS) $<
 
 qversionnumber.o: $(SOURCE_PATH)/src/corelib/tools/qversionnumber.cpp
@@ -407,7 +407,7 @@ qabstractfileengine.o: $(SOURCE_PATH)/src/corelib/io/qabstractfileengine.cpp
 qtemporaryfile.o: $(SOURCE_PATH)/src/corelib/io/qtemporaryfile.cpp
 	$(CXX) -c -o $@ $(CXXFLAGS) $<
 
-qregexp.o: $(SOURCE_PATH)/src/corelib/tools/qregexp.cpp
+qregexp.o: $(SOURCE_PATH)/src/corelib/text/qregexp.cpp
 	$(CXX) -c -o $@ $(CXXFLAGS) $<
 
 qbitarray.o: $(SOURCE_PATH)/src/corelib/tools/qbitarray.cpp
@@ -428,7 +428,7 @@ qfileinfo.o: $(SOURCE_PATH)/src/corelib/io/qfileinfo.cpp
 qdatetime.o: $(SOURCE_PATH)/src/corelib/time/qdatetime.cpp
 	$(CXX) -c -o $@ $(CXXFLAGS) $<
 
-qstringlist.o: $(SOURCE_PATH)/src/corelib/tools/qstringlist.cpp
+qstringlist.o: $(SOURCE_PATH)/src/corelib/text/qstringlist.cpp
 	$(CXX) -c -o $@ $(CXXFLAGS) $<
 
 qmap.o: $(SOURCE_PATH)/src/corelib/tools/qmap.cpp

qmake/Makefile.win32

@@ -196,6 +196,9 @@ qmake_pch.obj:
 {$(SOURCE_PATH)\src\corelib\serialization}.cpp{}.obj::
 	$(CXX) $(CXXFLAGS) $<
 
+{$(SOURCE_PATH)\src\corelib\text}.cpp{}.obj::
+	$(CXX) $(CXXFLAGS) $<
+
 {$(SOURCE_PATH)\src\corelib\time}.cpp{}.obj::
 	$(CXX) $(CXXFLAGS) $<
 

src/corelib/configure.json

@@ -596,7 +596,7 @@
                     "qDoubleSnprintf(argv[0], 1, invalidLocale, \"invalid format\", a);",
                     "qDoubleSscanf(argv[0], invalidLocale, \"invalid format\", &a, &argc);"
                 ],
-                "qmake": "DEFINES += QDSP_P_H=$$shell_quote(\\\"@PWD@/tools/qdoublescanprint_p.h\\\")"
+                "qmake": "DEFINES += QDSP_P_H=$$shell_quote(\\\"@PWD@/text/qdoublescanprint_p.h\\\")"
             }
         }
     },

src/corelib/corelib.pro

@@ -36,6 +36,7 @@ qtConfig(animation): include(animation/animation.pri)
 include(global/global.pri)
 include(thread/thread.pri)
 include(tools/tools.pri)
+include(text/text.pri)
 include(time/time.pri)
 include(io/io.pri)
 include(itemmodels/itemmodels.pri)

src/corelib/text/qbytearray.cpp

@@ -40,7 +40,7 @@
 
 #include "qbytearray.h"
 #include "qbytearraymatcher.h"
-#include "qtools_p.h"
+#include "private/qtools_p.h"
 #include "qstring.h"
 #include "qlist.h"
 #include "qlocale.h"

src/corelib/text/qbytearray_p.h

@@ -52,7 +52,7 @@
 //
 
 #include <QtCore/qbytearray.h>
-#include "qtools_p.h"
+#include "private/qtools_p.h"
 
 QT_BEGIN_NAMESPACE
 

src/corelib/text/qstring.cpp

@@ -49,8 +49,8 @@
 #include <qtextcodec.h>
 #endif
 #include <private/qutfcodec_p.h>
-#include <private/qlocale_tools_p.h>
+#include "qlocale_tools_p.h"
-#include "qsimd_p.h"
+#include "private/qsimd_p.h"
 #include <qnumeric.h>
 #include <qdatastream.h>
 #include <qlist.h>
@@ -59,7 +59,6 @@
 #include "qstringbuilder.h"
 #include "qstringmatcher.h"
 #include "qvarlengtharray.h"
-#include "qtools_p.h"
 #include "qdebug.h"
 #include "qendian.h"
 #include "qcollator.h"

src/corelib/text/text.pri

@@ -0,0 +1,100 @@
+# Qt text / string / character / unicode / byte array module
+
+HEADERS +=  \
+        text/qbytearray.h \
+        text/qbytearray_p.h \
+        text/qbytearraylist.h \
+        text/qbytearraymatcher.h \
+        text/qbytedata_p.h \
+        text/qchar.h \
+        text/qcollator.h \
+        text/qcollator_p.h \
+        tools/qdoublescanprint_p.h \
+        text/qlocale.h \
+        text/qlocale_p.h \
+        text/qlocale_tools_p.h \
+        text/qlocale_data_p.h \
+        text/qregexp.h \
+        text/qstring.h \
+        text/qstringalgorithms.h \
+        text/qstringalgorithms_p.h \
+        text/qstringbuilder.h \
+        text/qstringiterator_p.h \
+        text/qstringlist.h \
+        text/qstringliteral.h \
+        text/qstringmatcher.h \
+        text/qstringview.h \
+        text/qtextboundaryfinder.h \
+        text/qunicodetables_p.h \
+        text/qunicodetools_p.h
+
+
+SOURCES += \
+        text/qbytearray.cpp \
+        text/qbytearraylist.cpp \
+        text/qbytearraymatcher.cpp \
+        text/qcollator.cpp \
+        text/qlocale.cpp \
+        text/qlocale_tools.cpp \
+        text/qregexp.cpp \
+        text/qstring.cpp \
+        text/qstringbuilder.cpp \
+        text/qstringlist.cpp \
+        text/qstringview.cpp \
+        text/qtextboundaryfinder.cpp \
+        text/qunicodetools.cpp \
+        text/qvsnprintf.cpp
+
+NO_PCH_SOURCES += text/qstring_compat.cpp
+false: SOURCES += $$NO_PCH_SOURCES # Hack for QtCreator
+
+!nacl:macos: {
+    SOURCES += text/qlocale_mac.mm
+}
+else:unix {
+    SOURCES += text/qlocale_unix.cpp
+}
+else:win32 {
+    SOURCES += text/qlocale_win.cpp
+} else:integrity {
+    SOURCES += text/qlocale_unix.cpp
+}
+
+qtConfig(icu) {
+    QMAKE_USE_PRIVATE += icu
+
+    SOURCES += text/qlocale_icu.cpp \
+               text/qcollator_icu.cpp
+} else: win32 {
+    SOURCES += text/qcollator_win.cpp
+} else: macos {
+    SOURCES += text/qcollator_macx.cpp
+} else {
+    SOURCES += text/qcollator_posix.cpp
+}
+
+qtConfig(regularexpression) {
+    QMAKE_USE_PRIVATE += pcre2
+
+    HEADERS += \
+        text/qregularexpression.h
+    SOURCES += text/qregularexpression.cpp
+}
+
+INCLUDEPATH += ../3rdparty/harfbuzz/src
+HEADERS += ../3rdparty/harfbuzz/src/harfbuzz.h
+SOURCES += ../3rdparty/harfbuzz/src/harfbuzz-buffer.c \
+           ../3rdparty/harfbuzz/src/harfbuzz-gdef.c \
+           ../3rdparty/harfbuzz/src/harfbuzz-gsub.c \
+           ../3rdparty/harfbuzz/src/harfbuzz-gpos.c \
+           ../3rdparty/harfbuzz/src/harfbuzz-impl.c \
+           ../3rdparty/harfbuzz/src/harfbuzz-open.c \
+           ../3rdparty/harfbuzz/src/harfbuzz-stream.c \
+           ../3rdparty/harfbuzz/src/harfbuzz-shaper-all.cpp \
+           text/qharfbuzz.cpp
+HEADERS += text/qharfbuzz_p.h
+
+TR_EXCLUDE += ../3rdparty/*
+
+# MIPS DSP
+MIPS_DSP_ASM += text/qstring_mips_dsp_asm.S

src/corelib/tools/tools.pri

@@ -8,19 +8,10 @@ HEADERS +=  \
         tools/qarraydataops.h \
         tools/qarraydatapointer.h \
         tools/qbitarray.h \
-        tools/qbytearray.h \
-        tools/qbytearray_p.h \
-        tools/qbytearraylist.h \
-        tools/qbytearraymatcher.h \
-        tools/qbytedata_p.h \
         tools/qcache.h \
-        tools/qchar.h \
-        tools/qcollator.h \
-        tools/qcollator_p.h \
         tools/qcontainerfwd.h \
         tools/qcontainertools_impl.h \
         tools/qcryptographichash.h \
-        tools/qdoublescanprint_p.h \
         tools/qeasingcurve.h \
         tools/qfreelist_p.h \
         tools/qhash.h \
@@ -29,10 +20,6 @@ HEADERS +=  \
         tools/qline.h \
         tools/qlinkedlist.h \
         tools/qlist.h \
-        tools/qlocale.h \
-        tools/qlocale_p.h \
-        tools/qlocale_tools_p.h \
-        tools/qlocale_data_p.h \
         tools/qmakearray_p.h \
         tools/qmap.h \
         tools/qmargins.h \
@@ -43,7 +30,6 @@ HEADERS +=  \
         tools/qpoint.h \
         tools/qqueue.h \
         tools/qrect.h \
-        tools/qregexp.h \
         tools/qringbuffer_p.h \
         tools/qrefcount.h \
         tools/qscopeguard.h \
@@ -57,20 +43,8 @@ HEADERS +=  \
         tools/qsimd_p.h \
         tools/qsize.h \
         tools/qstack.h \
-        tools/qstring.h \
-        tools/qstringalgorithms.h \
-        tools/qstringalgorithms_p.h \
-        tools/qstringbuilder.h \
-        tools/qstringiterator_p.h \
-        tools/qstringlist.h \
-        tools/qstringliteral.h \
-        tools/qstringmatcher.h \
-        tools/qstringview.h \
-        tools/qtextboundaryfinder.h \
         tools/qtimeline.h \
         tools/qtools_p.h \
-        tools/qunicodetables_p.h \
-        tools/qunicodetools_p.h \
         tools/qvarlengtharray.h \
         tools/qvector.h \
         tools/qversionnumber.h
@@ -79,10 +53,6 @@ HEADERS +=  \
 SOURCES += \
         tools/qarraydata.cpp \
         tools/qbitarray.cpp \
-        tools/qbytearray.cpp \
-        tools/qbytearraylist.cpp \
-        tools/qbytearraymatcher.cpp \
-        tools/qcollator.cpp \
         tools/qcryptographichash.cpp \
         tools/qeasingcurve.cpp \
         tools/qfreelist.cpp \
@@ -90,47 +60,24 @@ SOURCES += \
         tools/qline.cpp \
         tools/qlinkedlist.cpp \
         tools/qlist.cpp \
-        tools/qlocale.cpp \
-        tools/qlocale_tools.cpp \
         tools/qpoint.cpp \
         tools/qmap.cpp \
         tools/qmargins.cpp \
         tools/qmessageauthenticationcode.cpp \
         tools/qcontiguouscache.cpp \
         tools/qrect.cpp \
-        tools/qregexp.cpp \
         tools/qrefcount.cpp \
         tools/qringbuffer.cpp \
         tools/qshareddata.cpp \
         tools/qsharedpointer.cpp \
         tools/qsimd.cpp \
         tools/qsize.cpp \
-        tools/qstring.cpp \
-        tools/qstringbuilder.cpp \
-        tools/qstringlist.cpp \
-        tools/qstringview.cpp \
-        tools/qtextboundaryfinder.cpp \
         tools/qtimeline.cpp \
-        tools/qunicodetools.cpp \
-        tools/qvsnprintf.cpp \
         tools/qversionnumber.cpp
 
-NO_PCH_SOURCES = tools/qstring_compat.cpp
 msvc: NO_PCH_SOURCES += tools/qvector_msvc.cpp
 false: SOURCES += $$NO_PCH_SOURCES # Hack for QtCreator
 
-!nacl:mac: {
-    SOURCES += tools/qlocale_mac.mm
-}
-else:unix {
-    SOURCES += tools/qlocale_unix.cpp
-}
-else:win32 {
-    SOURCES += tools/qlocale_win.cpp
-} else:integrity {
-    SOURCES += tools/qlocale_unix.cpp
-}
-
 qtConfig(system-zlib) {
     include($$PWD/../../3rdparty/zlib_dependency.pri)
 } else {
@@ -138,27 +85,6 @@ qtConfig(system-zlib) {
     include($$PWD/../../3rdparty/zlib.pri)
 }
 
-qtConfig(icu) {
-    QMAKE_USE_PRIVATE += icu
-
-    SOURCES += tools/qlocale_icu.cpp \
-               tools/qcollator_icu.cpp
-} else: win32 {
-    SOURCES += tools/qcollator_win.cpp
-} else: macx {
-    SOURCES += tools/qcollator_macx.cpp
-} else {
-    SOURCES += tools/qcollator_posix.cpp
-}
-
-qtConfig(regularexpression) {
-    QMAKE_USE_PRIVATE += pcre2
-
-    HEADERS += \
-        tools/qregularexpression.h
-    SOURCES += tools/qregularexpression.cpp
-}
-
 qtConfig(commandlineparser) {
     HEADERS += \
         tools/qcommandlineoption.h \
@@ -168,19 +94,6 @@ qtConfig(commandlineparser) {
         tools/qcommandlineparser.cpp
 }
 
-INCLUDEPATH += ../3rdparty/harfbuzz/src
-HEADERS += ../3rdparty/harfbuzz/src/harfbuzz.h
-SOURCES += ../3rdparty/harfbuzz/src/harfbuzz-buffer.c \
-           ../3rdparty/harfbuzz/src/harfbuzz-gdef.c \
-           ../3rdparty/harfbuzz/src/harfbuzz-gsub.c \
-           ../3rdparty/harfbuzz/src/harfbuzz-gpos.c \
-           ../3rdparty/harfbuzz/src/harfbuzz-impl.c \
-           ../3rdparty/harfbuzz/src/harfbuzz-open.c \
-           ../3rdparty/harfbuzz/src/harfbuzz-stream.c \
-           ../3rdparty/harfbuzz/src/harfbuzz-shaper-all.cpp \
-           tools/qharfbuzz.cpp
-HEADERS += tools/qharfbuzz_p.h
-
 INCLUDEPATH += ../3rdparty/md5 \
                ../3rdparty/md4 \
                ../3rdparty/sha3
@@ -197,5 +110,4 @@ unix:!macx-icc:!vxworks:!haiku:!integrity:!wasm: LIBS_PRIVATE += -lm
 TR_EXCLUDE += ../3rdparty/*
 
 # MIPS DSP
-MIPS_DSP_ASM += tools/qstring_mips_dsp_asm.S
 MIPS_DSP_HEADERS += ../gui/painting/qt_mips_asm_dsp_p.h

src/tools/bootstrap/bootstrap.pro

@@ -74,32 +74,32 @@ SOURCES += \
            ../../corelib/serialization/qtextstream.cpp \
            ../../corelib/serialization/qxmlutils.cpp \
            ../../corelib/serialization/qxmlstream.cpp \
+           ../../corelib/text/qbytearray.cpp \
+           ../../corelib/text/qbytearraymatcher.cpp \
+           ../../corelib/text/qlocale.cpp \
+           ../../corelib/text/qlocale_tools.cpp \
+           ../../corelib/text/qregexp.cpp \
+           ../../corelib/text/qstring.cpp \
+           ../../corelib/text/qstringbuilder.cpp \
+           ../../corelib/text/qstring_compat.cpp \
+           ../../corelib/text/qstringlist.cpp \
+           ../../corelib/text/qstringview.cpp \
+           ../../corelib/text/qvsnprintf.cpp \
            ../../corelib/time/qdatetime.cpp \
-           ../../corelib/tools/qbitarray.cpp \
-           ../../corelib/tools/qbytearray.cpp \
            ../../corelib/tools/qarraydata.cpp \
-           ../../corelib/tools/qbytearraymatcher.cpp \
+           ../../corelib/tools/qbitarray.cpp \
            ../../corelib/tools/qcommandlineparser.cpp \
            ../../corelib/tools/qcommandlineoption.cpp \
            ../../corelib/tools/qcryptographichash.cpp \
            ../../corelib/tools/qhash.cpp \
            ../../corelib/tools/qlist.cpp \
-           ../../corelib/tools/qlocale.cpp \
-           ../../corelib/tools/qlocale_tools.cpp \
            ../../corelib/tools/qmap.cpp \
-           ../../corelib/tools/qregexp.cpp \
            ../../corelib/tools/qringbuffer.cpp \
            ../../corelib/tools/qpoint.cpp \
            ../../corelib/tools/qrect.cpp \
            ../../corelib/tools/qsize.cpp \
            ../../corelib/tools/qline.cpp \
-           ../../corelib/tools/qstring.cpp \
-           ../../corelib/tools/qstringbuilder.cpp \
-           ../../corelib/tools/qstring_compat.cpp \
-           ../../corelib/tools/qstringlist.cpp \
-           ../../corelib/tools/qstringview.cpp \
            ../../corelib/tools/qversionnumber.cpp \
-           ../../corelib/tools/qvsnprintf.cpp \
            ../../xml/dom/qdom.cpp \
            ../../xml/sax/qxml.cpp
 

tests/auto/corelib/corelib.pro

@@ -13,6 +13,7 @@ SUBDIRS = \
    plugin \
    serialization \
    statemachine \
+   text \
    thread \
    time \
    tools