From a905c3e68342629e5d5ec2e3d9ec862b730087b4 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Mon, 18 Jul 2022 10:24:37 +0200 Subject: [PATCH] Eradicate QT_STRINGVIEW_LEVEL It was designed to gauge the impact of replacing QString functions with QStringView ones, as opposed to just overloading, but that never came to pass, for two reasons: 1. We never got to implement a full set of overloads with the pattern in a large enough library (QtCore) for results to matter. 2. QStringView doesn't accept everything that QString accepts, making it unsuitable as a drop-in replacement (QAnyStringView has that property, though, but we never added a QT_ANYSTRINGVIEW_LEVEL macro). So, R.I.P. QT_STRINGVIEW_LEVEL. Fixes: QTBUG-100861 Change-Id: I0a9318177acb295e8eeeddfb345449112070c597 Reviewed-by: Sona Kurazyan Reviewed-by: Edward Welbourne (cherry picked from commit 046a5a8f4f49944e6bf94cded52f88535d16bb3f) Reviewed-by: Qt Cherry-pick Bot --- src/corelib/text/qstringview.h | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/corelib/text/qstringview.h b/src/corelib/text/qstringview.h index 3f0812e2e74..d820ec8ad0d 100644 --- a/src/corelib/text/qstringview.h +++ b/src/corelib/text/qstringview.h @@ -4,13 +4,6 @@ #ifndef QSTRINGVIEW_H #define QSTRINGVIEW_H -/* - Obsolete. -*/ -#ifndef QT_STRINGVIEW_LEVEL -# define QT_STRINGVIEW_LEVEL 1 -#endif - #include #include #include