1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prevent linker error in tst_qfloat16::ordering on VxWorks

Browse Source 
tst_qfloat16::ordering tests that qfloat16 can be compared with a long
double. When on x86_64, conversion from qfloat16 to long double leads to
a linker error due to undefined reference to __extendhfxf2.  This is a
bug in the VxWorks' toolchain. It has been acknowledged by WindRiver and
it's being tracked in ticket 00154117.

Since
- this is a platform problem and Qt has no control over it,
- the conversion won't work for any client code anyway, so not testing it
  is not hiding any issues,
mitigate the problem for now by not compiling the problematic test code
on VxWorks.

Task-number: QTBUG-115777
Change-Id: Icf81da405d1392ae3bcacc61745a54d68b849b89
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
(cherry picked from commit 6ef631c7992cc81ead158c5c5801f689b21fc378)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Łukasz Matysiak 2024-08-29 15:43:00 +02:00 committed by Qt Cherry-pick Bot
parent 02510e11a9
commit a87db277ce
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/auto/corelib/global/qfloat16/tst_qfloat16.cpp
View File

@ -184,7 +184,13 @@ void tst_qfloat16::ordering()
CHECK_FP(qfloat16);
CHECK_FP(float);
CHECK_FP(double);
// Qt built for VxWorks x86_64 fails to link due to undefined reference to
// __extendhfxf2 when below check is enabled.
// This has been acknowledged by WindRiver as a bug
// and is being tracked in ticket 00154117
#if !(defined(Q_OS_VXWORKS) && defined(Q_PROCESSOR_X86_64))
CHECK_FP(long double);
#endif
#undef CHECK_FP