From a7db6e34670b946c38e46ed28d8146c271c6c130 Mon Sep 17 00:00:00 2001 From: Andrey Bienkowski Date: Mon, 9 Nov 2015 08:21:12 +0300 Subject: [PATCH] Fixed memory leaks in the "40000 chips" example. Two QObjects had no parent. This caused memory leaks on app close. Confirmed with the valgrind memory analyzer tool from Qt Creator. Change-Id: I9294099ca819be1a9c5b74b3cec5bf197be06433 Reviewed-by: Marc Mutz --- examples/widgets/graphicsview/chip/mainwindow.cpp | 2 +- examples/widgets/graphicsview/chip/view.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/widgets/graphicsview/chip/mainwindow.cpp b/examples/widgets/graphicsview/chip/mainwindow.cpp index f88c3585137..85d1c1c1fe6 100644 --- a/examples/widgets/graphicsview/chip/mainwindow.cpp +++ b/examples/widgets/graphicsview/chip/mainwindow.cpp @@ -76,7 +76,7 @@ MainWindow::MainWindow(QWidget *parent) void MainWindow::populateScene() { - scene = new QGraphicsScene; + scene = new QGraphicsScene(this); QImage image(":/qt4logo.png"); diff --git a/examples/widgets/graphicsview/chip/view.cpp b/examples/widgets/graphicsview/chip/view.cpp index 0a4179b3645..8c1fc79f5bb 100644 --- a/examples/widgets/graphicsview/chip/view.cpp +++ b/examples/widgets/graphicsview/chip/view.cpp @@ -147,7 +147,7 @@ View::View(const QString &name, QWidget *parent) printButton = new QToolButton; printButton->setIcon(QIcon(QPixmap(":/fileprint.png"))); - QButtonGroup *pointerModeGroup = new QButtonGroup; + QButtonGroup *pointerModeGroup = new QButtonGroup(this); pointerModeGroup->setExclusive(true); pointerModeGroup->addButton(selectModeButton); pointerModeGroup->addButton(dragModeButton);