1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MimeTypeBrowser: avoid memleaks

Browse Source 
In MainWindow ctor some member values were allocated without a parent
and not cleaned up in dtor. Fixed it by give them a valid parent so they
get automatically cleaned up. Also m_treeView was initialized twice.

Task-number: QTBUG-61862
Change-Id: I5590b87bb517c55db6eb58e700a5d419c0acdba2
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
Reviewed-by: Martin Smith <martin.smith@qt.io>
This commit is contained in:
Christian Ehrlicher 2017-12-24 13:22:48 +01:00
parent d733014019
commit a779d68256
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
examples/corelib/mimetypes/mimetypebrowser/mainwindow.cpp
View File

@ -72,8 +72,8 @@
MainWindow::MainWindow(QWidget *parent) MainWindow::MainWindow(QWidget *parent)
: QMainWindow(parent) : QMainWindow(parent)
, m_model(new MimetypeModel(this)) , m_model(new MimetypeModel(this))
, m_treeView(new QTreeView) , m_treeView(new QTreeView(this))
, m_detailsText(new QTextEdit) , m_detailsText(new QTextEdit(this))
, m_findIndex(0) , m_findIndex(0)
{ {
setWindowTitle(tr("Qt Mime Database Browser")); setWindowTitle(tr("Qt Mime Database Browser"));
@ -97,9 +97,8 @@ MainWindow::MainWindow(QWidget *parent)
menuBar()->addMenu(tr("&About"))->addAction(tr("&About Qt"), qApp, &QApplication::aboutQt); menuBar()->addMenu(tr("&About"))->addAction(tr("&About Qt"), qApp, &QApplication::aboutQt);
QSplitter *centralSplitter = new QSplitter; QSplitter *centralSplitter = new QSplitter(this);
setCentralWidget(centralSplitter); setCentralWidget(centralSplitter);
m_treeView = new QTreeView;
m_treeView->setUniformRowHeights(true); m_treeView->setUniformRowHeights(true);
m_treeView->setModel(m_model); m_treeView->setModel(m_model);