1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Micro]Optimize QStyleSheetStyle::subElementRect

Browse Source 
No need to make a QStyleOptionButton copy, we can just use the pointer
we already have

Change-Id: I3ef5f59eb4fe25adf675e67ebf548f4358456379
Reviewed-by: Christian Ehrlicher <ch.ehrlicher@gmx.de>
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
This commit is contained in:
Albert Astals Cid 2018-10-30 15:50:39 +01:00
parent fe999230ec
commit a76f8caf29
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/widgets/styles/qstylesheetstyle.cpp
View File

@ -5777,11 +5777,10 @@ QRect QStyleSheetStyle::subElementRect(SubElement se, const QStyleOption *opt, c
case SE_PushButtonContents: case SE_PushButtonContents:
case SE_PushButtonFocusRect: case SE_PushButtonFocusRect:
if (const QStyleOptionButton *btn = qstyleoption_cast<const QStyleOptionButton *>(opt)) { if (const QStyleOptionButton *btn = qstyleoption_cast<const QStyleOptionButton *>(opt)) {
QStyleOptionButton btnOpt(*btn);
if (rule.hasBox() || !rule.hasNativeBorder()) if (rule.hasBox() || !rule.hasNativeBorder())
return visualRect(opt->direction, opt->rect, rule.contentsRect(opt->rect)); return visualRect(opt->direction, opt->rect, rule.contentsRect(opt->rect));
return rule.baseStyleCanDraw() ? baseStyle()->subElementRect(se, &btnOpt, w) return rule.baseStyleCanDraw() ? baseStyle()->subElementRect(se, btn, w)
: QWindowsStyle::subElementRect(se, &btnOpt, w); : QWindowsStyle::subElementRect(se, btn, w);
} }
break; break;