From a506e0835e3fe92dfe26bdc6080d4f2ebd0e5220 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A5rten=20Nordheim?= Date: Fri, 1 Sep 2023 10:33:05 +0200 Subject: [PATCH] tst_QString: deduplicate datatags By saying what's special about some of them Change-Id: I17bf2e12a27bf55f621020ddf3819ee9e606847d Reviewed-by: Edward Welbourne Reviewed-by: Thiago Macieira (cherry picked from commit 6577242adff254724c739637a92372839c29da04) Reviewed-by: Qt Cherry-pick Bot --- .../auto/corelib/text/qstring/tst_qstring.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/auto/corelib/text/qstring/tst_qstring.cpp b/tests/auto/corelib/text/qstring/tst_qstring.cpp index eaf35c969ea..819335ca35e 100644 --- a/tests/auto/corelib/text/qstring/tst_qstring.cpp +++ b/tests/auto/corelib/text/qstring/tst_qstring.cpp @@ -4324,18 +4324,18 @@ void tst_QString::toNum_base_data() QTest::newRow("77") << u"77"_s << 8 << 63; QTest::newRow("077") << u"077"_s << 8 << 63; - QTest::newRow("0xFF") << u"0xFF"_s << 0 << 255; - QTest::newRow("077") << u"077"_s << 0 << 63; - QTest::newRow("255") << u"255"_s << 0 << 255; + QTest::newRow("0xFF - deduced base") << u"0xFF"_s << 0 << 255; + QTest::newRow("077 - deduced base") << u"077"_s << 0 << 63; + QTest::newRow("255 - deduced base") << u"255"_s << 0 << 255; QTest::newRow(" FF") << u" FF"_s << 16 << 255; QTest::newRow(" 0xFF") << u" 0xFF"_s << 16 << 255; QTest::newRow(" 77") << u" 77"_s << 8 << 63; QTest::newRow(" 077") << u" 077"_s << 8 << 63; - QTest::newRow(" 0xFF") << u" 0xFF"_s << 0 << 255; - QTest::newRow(" 077") << u" 077"_s << 0 << 63; - QTest::newRow(" 255") << u" 255"_s << 0 << 255; + QTest::newRow(" 0xFF - deduced base") << u" 0xFF"_s << 0 << 255; + QTest::newRow(" 077 - deduced base") << u" 077"_s << 0 << 63; + QTest::newRow(" 255 - deduced base") << u" 255"_s << 0 << 255; QTest::newRow("\tFF\t") << u"\tFF\t"_s << 16 << 255; QTest::newRow("\t0xFF ") << u"\t0xFF "_s << 16 << 255; @@ -4386,9 +4386,9 @@ void tst_QString::toNum_base_neg_data() QTest::newRow("-77") << u"-77"_s << 8 << -63; QTest::newRow("-077") << u"-077"_s << 8 << -63; - QTest::newRow("-0xFE") << u"-0xFE"_s << 0 << -254; - QTest::newRow("-077") << u"-077"_s << 0 << -63; - QTest::newRow("-254") << u"-254"_s << 0 << -254; + QTest::newRow("-0xFE - deduced base") << u"-0xFE"_s << 0 << -254; + QTest::newRow("-077 - deduced base") << u"-077"_s << 0 << -63; + QTest::newRow("-254 - deduced base") << u"-254"_s << 0 << -254; } void tst_QString::toNum_base_neg()