1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tst_QSet: check whether QSet::removeIf() can modify elements

Browse Source 
It can't, pfew. Was wondering for a moment, but of course, even the
QSet::iterator is really a const_iterator.

Pick-to: 6.9 6.8 6.5 6.2
Change-Id: I85caa64c1caca6d77569aa2ceb868a4aa0e5578d
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
Reviewed-by: Magdalena Stojek <magdalena.stojek@qt.io>
Reviewed-by: Lena Biliaieva <lena.biliaieva@qt.io>
This commit is contained in:
Marc Mutz 2025-01-17 16:11:21 +01:00
parent 768ab20517
commit a4fd95c51a
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/auto/corelib/tools/qset/tst_qset.cpp
View File

@ -33,6 +33,7 @@ private slots:
void cpp17ctad(); void cpp17ctad();
void remove(); void remove();
void removeOnlyDetachesIfSomethingGetsRemoved(); void removeOnlyDetachesIfSomethingGetsRemoved();
void removeIfDoesNotAllowThePredicateToModifyTheElement();
void contains(); void contains();
void containsSet(); void containsSet();
void begin(); void begin();
@ -424,6 +425,17 @@ void tst_QSet::removeOnlyDetachesIfSomethingGetsRemoved()
QVERIFY(copy.isDetached()); QVERIFY(copy.isDetached());
} }
void tst_QSet::removeIfDoesNotAllowThePredicateToModifyTheElement()
{
QSet<int> set = {0, 1, 2, 3};
set.removeIf([](auto &&e) {
if constexpr (!std::is_const_v<std::remove_reference_t<decltype(e)>>)
e *= 2;
return false;
});
QCOMPARE(set, QSet({0, 1, 2, 3}));
}
void tst_QSet::contains() void tst_QSet::contains()
{ {
QSet<QString> set1; QSet<QString> set1;