From a37957df5c1d3d8624fae2222734a127ec340a72 Mon Sep 17 00:00:00 2001
From: Alexandru Croitor <alexandru.croitor@qt.io>
Date: Fri, 11 Jun 2021 17:25:59 +0200
Subject: [PATCH] CMake: Add TODO to apply generalized object library linking
 approach

Pick-to: 6.2
Change-Id: I1ea368e81d8b055ef353a0f021f188b45588c937
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
---
 cmake/QtPublicPluginHelpers.cmake | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/cmake/QtPublicPluginHelpers.cmake b/cmake/QtPublicPluginHelpers.cmake
index 8c98852c49f..ce8ddf0bee2 100644
--- a/cmake/QtPublicPluginHelpers.cmake
+++ b/cmake/QtPublicPluginHelpers.cmake
@@ -195,6 +195,9 @@ function(__qt_internal_add_static_plugin_import_macro
     __qt_internal_get_static_plugin_init_target_name("${plugin_target}" plugin_init_target)
     set(objs_genex "$<TARGET_OBJECTS:${QT_CMAKE_EXPORT_NAMESPACE}::${plugin_init_target}>")
 
+    # TODO: Replace the target_sources call here with the more generalized approach that will be
+    # added to __qt_propagate_generated_resource (the one that determines whether to use
+    # target_sources or target_link_libraries depending on the CMake version).
     target_sources(${QT_CMAKE_EXPORT_NAMESPACE}::${plugin_target} INTERFACE
                    "${objs_genex}")
 endfunction()