From a25f9a15076782154bf7cf58e3c5af29a7b6653e Mon Sep 17 00:00:00 2001 From: Albert Astals Cid Date: Tue, 19 Feb 2019 17:37:30 +0100 Subject: [PATCH] cmake: Start adding compiler flags Only has warnings for now Next to come is the support for developer-build and enabling Werror Change-Id: I8070dc06eb439c2a03007cce975c8147ff7e1582 Reviewed-by: Kevin Funk --- cmake/QtBaseGlobalTargets.cmake | 1 + cmake/QtCompilerFlags.cmake | 6 ++++++ cmake/QtSetup.cmake | 3 +++ 3 files changed, 10 insertions(+) create mode 100644 cmake/QtCompilerFlags.cmake diff --git a/cmake/QtBaseGlobalTargets.cmake b/cmake/QtBaseGlobalTargets.cmake index 6074f1233c0..73deb51b494 100644 --- a/cmake/QtBaseGlobalTargets.cmake +++ b/cmake/QtBaseGlobalTargets.cmake @@ -64,6 +64,7 @@ install(EXPORT "${INSTALL_CMAKE_NAMESPACE}Targets" NAMESPACE ${INSTALL_CMAKE_EXP ## Install some QtBase specific CMake files: install(FILES cmake/QtBuild.cmake + cmake/QtCompilerFlags.cmake cmake/QtCompilerOptimization.cmake cmake/QtFeature.cmake cmake/QtPlatformSupport.cmake diff --git a/cmake/QtCompilerFlags.cmake b/cmake/QtCompilerFlags.cmake new file mode 100644 index 00000000000..35733027f50 --- /dev/null +++ b/cmake/QtCompilerFlags.cmake @@ -0,0 +1,6 @@ +# Set warnings. All compilers except MSVC support -Wall -Wextra +if (MSVC) + add_compile_options(/W3) +else() + add_compile_options(-Wall -Wextra) +endif() diff --git a/cmake/QtSetup.cmake b/cmake/QtSetup.cmake index a90f12d0c22..caf908b4c9d 100644 --- a/cmake/QtSetup.cmake +++ b/cmake/QtSetup.cmake @@ -42,6 +42,9 @@ include(QtFeature) ## Compiler optimization flags: include(QtCompilerOptimization) +## Compiler flags: +include(QtCompilerFlags) + ## Find host tools (if non native): set(HOST_QT_TOOLS_DIRECTORY "" CACHE PATH "Directory with Qt host tools.")