1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix strange capacity check in tst_QString::append_special_cases

Browse Source 
We cannot rely on "QString a; a.insert(0, u'A');" to give
a.capacity() >= 3, this is clearly an implementation detail. Changed
the check to a meaningful one

Task-number: QTBUG-87416
Change-Id: I2e017c1292d360e32b85b903361027485c08ea74
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Andrei Golubev 2020-10-13 16:52:10 +02:00
parent e69b81101c
commit a17e05bf20
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/auto/corelib/text/qstring/tst_qstring.cpp
View File

@ -2467,7 +2467,8 @@ void tst_QString::append_special_cases()
{
QString a;
a.insert(0, QChar(u'A'));
QVERIFY(a.capacity() >= 3);
QCOMPARE(a.size(), 1);
QVERIFY(a.capacity() > 0);
a.append(QLatin1String("BC"));
QCOMPARE(a, QLatin1String("ABC"));
}