1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wasm: Fix parsing HTTP header values that contain colon (:)

Browse Source 
According to RFC 7230 header values can contain colon(:). Fix
parsing HTTP headers to handle such cases correctly.

Fixes: QTBUG-136812
Pick-to: 6.5 6.8 6.9
Change-Id: I371342c5d84744e0427eb23fb1b648f8c0f0c9fe
Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io>
This commit is contained in:
Piotr Wiercinski 2025-05-14 21:53:15 +02:00 committed by Piotr Wierciński
parent a65554044c
commit a13d84b56a
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/network/access/qnetworkreplywasmimpl.cpp
View File

@ -426,20 +426,22 @@ void QNetworkReplyWasmImplPrivate::headersReceived(const QByteArray &buffer)
if (!buffer.isEmpty()) {
QList<QByteArray> headers = buffer.split('\n');
for (int i = 0; i < headers.size(); i++) {
if (headers.at(i).contains(':')) { // headers include final \x00, so skip
QByteArray headerName = headers.at(i).split(':').at(0).trimmed();
QByteArray headersValue = headers.at(i).split(':').at(1).trimmed();
for (auto &&header : headers) {
if (auto splitPos = header.indexOf(':');
splitPos != -1) { // headers include final \x00, so skip
auto headerName = header.first(splitPos).trimmed();
auto headerValue = header.sliced(splitPos + 1).trimmed();
if (headerName.isEmpty() || headersValue.isEmpty())
if (headerName.isEmpty() || headerValue.isEmpty())
continue;
int headerIndex = parseHeaderName(headerName);
if (headerIndex == -1)
q->setRawHeader(headerName, headersValue);
q->setRawHeader(headerName, headerValue);
else
q->setHeader(static_cast<QNetworkRequest::KnownHeaders>(headerIndex), (QVariant)headersValue);
q->setHeader(static_cast<QNetworkRequest::KnownHeaders>(headerIndex),
(QVariant)headerValue);
}
}
}