From a12a3c6c8c07c0fe52589cea473ac95e556052c7 Mon Sep 17 00:00:00 2001 From: Joerg Bornemann Date: Mon, 6 Mar 2017 12:46:28 +0100 Subject: [PATCH] Fix MSVC Makefiles when SOURCES is empty Call sites of NmakeMakefileGenerator::writeResponseFileFiles expect that the output is terminated with '\n'. Do not bail out if files is empty. Task-number: QTBUG-59305 Change-Id: Id3fef8dbc506dad1868e6b352119f5f27b50a368 Reviewed-by: Oswald Buddenhagen --- qmake/generators/win32/msvc_nmake.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/qmake/generators/win32/msvc_nmake.cpp b/qmake/generators/win32/msvc_nmake.cpp index 0b0efe4acfd..8ac462da6bf 100644 --- a/qmake/generators/win32/msvc_nmake.cpp +++ b/qmake/generators/win32/msvc_nmake.cpp @@ -662,8 +662,6 @@ void NmakeMakefileGenerator::writeLinkCommand(QTextStream &t, const QString &ext void NmakeMakefileGenerator::writeResponseFileFiles(QTextStream &t, const ProStringList &files) { - if (files.isEmpty()) - return; // Add line breaks in file lists in reponse files to work around LNK1170. // The actual line length limit is 131070, but let's use a smaller limit // in case other tools are similarly hampered.