From 9ff4b5341fc30a6154e20d7c83a35f594c7ec92b Mon Sep 17 00:00:00 2001 From: Alexandru Croitor Date: Mon, 24 Mar 2025 12:57:41 +0100 Subject: [PATCH] CMake: Fix list(REMOVE_ITEM) usage with older CMakes Older CMakes error out with CMake Error at cmake/QtSyncQtHelpers.cmake:156 (list): list sub-command REMOVE_ITEM requires two or more arguments. if the last expanded variable is empty. Fix by doing an explicit non-emptiness check. Amends e7834e90f38891382f830da7700f00ebd81f21a8 Pick-to: 6.8 6.9 Task-number: QTBUG-134672 Task-number: QTBUG-128730 Change-Id: I3c355a02519c2c450235770b2ff8c92416615a9f Reviewed-by: Alexey Edelev --- cmake/QtSyncQtHelpers.cmake | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cmake/QtSyncQtHelpers.cmake b/cmake/QtSyncQtHelpers.cmake index 96669a03c32..76a88954901 100644 --- a/cmake/QtSyncQtHelpers.cmake +++ b/cmake/QtSyncQtHelpers.cmake @@ -153,7 +153,9 @@ function(qt_internal_target_sync_headers target # Filter out all headers that should be excluded from documentation generation. # Documentation generation shouldn't depend on headers like the dbus-generated ones. set(module_headers_for_docs "${module_headers}") - list(REMOVE_ITEM module_headers_for_docs ${module_headers_exclude_from_docs}) + if(module_headers_exclude_from_docs) + list(REMOVE_ITEM module_headers_for_docs ${module_headers_exclude_from_docs}) + endif() set(syncqt_staging_dir "${module_build_interface_include_dir}/.syncqt_staging")