From 9f0dc59cd62f7afd18b36e6064f2d4b8ff2a7c6c Mon Sep 17 00:00:00 2001
From: Volker Hilsheimer <volker.hilsheimer@qt.io>
Date: Thu, 1 Feb 2024 11:39:58 +0100
Subject: [PATCH] JNI: Don't use forwarding reference in ranged for

The elements we iterate over are always jobjects, i.e. POD, so iterating
over values is at least as efficient, and less unnecessarily clever.

Pick-to: 6.7
Change-Id: I6142dab84f3d37d82613ecf27cc03dde7810e541
Reviewed-by: Juha Vuolle <juha.vuolle@qt.io>
---
 src/corelib/kernel/qjniarray.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/corelib/kernel/qjniarray.h b/src/corelib/kernel/qjniarray.h
index bfa5ec7a7cc..16c02e087d8 100644
--- a/src/corelib/kernel/qjniarray.h
+++ b/src/corelib/kernel/qjniarray.h
@@ -300,7 +300,7 @@ public:
         if constexpr (std::is_same_v<T, jobject>) {
             QList<jobject> res;
             res.reserve(size());
-            for (auto &&element : *this)
+            for (auto element : *this)
                 res.append(element);
             return res;
         } else if constexpr (std::is_same_v<T, jbyte>) {