From 9e09677c1dd4da92735736a0fbcb703416bf4d6d Mon Sep 17 00:00:00 2001 From: David Skoland Date: Fri, 8 Jan 2021 12:57:47 +0100 Subject: [PATCH] Remove QtDBus includes Per the discussion of QTBUG-88831, we determined that module-wide imports are unfortunate, especially for compile times. Following this, all QtDBus includes have been replaced with the headers for the classes actually used in each file. Additionally, some cleanup of header file order and format has been performed in the changed files. Pick-to: 6.0 Change-Id: I62c1b75682a48422f0ba1168dd5d7bd0952808ac Reviewed-by: Qt CI Bot Reviewed-by: Volker Hilsheimer Reviewed-by: Edward Welbourne --- examples/dbus/complexpingpong/complexping.cpp | 17 +++++---- examples/dbus/complexpingpong/complexpong.cpp | 15 ++++---- examples/dbus/listnames/listnames.cpp | 11 ++++-- examples/dbus/pingpong/ping.cpp | 12 +++--- examples/dbus/pingpong/pong.cpp | 15 ++++---- .../remotecontrolledcar/controller/main.cpp | 2 +- .../qdbusextratypes/qdbusextratypes.cpp | 2 +- .../unix/dbusmenu/qdbusmenuadaptor.cpp | 20 +++++----- .../unix/dbusmenu/qdbusmenuadaptor_p.h | 7 ++-- .../unix/dbusmenu/qdbusmenuconnection.cpp | 23 +++++------ .../platform/unix/dbustray/qdbustrayicon.cpp | 31 ++++++++------- .../dbustray/qstatusnotifieritemadaptor_p.h | 8 ++-- .../unix/dbustray/qxdgnotificationproxy_p.h | 20 +++++----- src/gui/platform/unix/qgenericunixthemes.cpp | 38 ++++++++++--------- .../ibus/qibusinputcontextproxy.h | 18 +++++---- .../ibus/qibusplatforminputcontext.cpp | 27 +++++++------ .../platforminputcontexts/ibus/qibusproxy.cpp | 2 + .../platforminputcontexts/ibus/qibusproxy.h | 17 +++++---- .../ibus/qibusproxyportal.h | 17 +++++---- .../platforminputcontexts/ibus/qibustypes.cpp | 2 +- .../qxdgdesktopportalfiledialog.cpp | 6 +-- .../auto/dbus/qdbusabstractadaptor/myobject.h | 7 +++- .../qmyserver/qmyserver.cpp | 9 ++++- .../tst_qdbusabstractadaptor.cpp | 11 ++++-- .../dbus/qdbusabstractinterface/interface.h | 6 +-- .../qpinger/qpinger.cpp | 11 +++++- .../tst_qdbusabstractinterface.cpp | 13 ++++--- .../qdbusconnection/tst_qdbusconnection.cpp | 12 +++--- .../qdbusconnection/tst_qdbusconnection.h | 5 ++- .../tst_qdbusconnection_delayed.cpp | 3 +- .../tst_qdbusconnection_no_bus.cpp | 6 +-- .../tst_qdbusconnection_no_libdbus.cpp | 2 +- .../dbus/qdbuscontext/tst_qdbuscontext.cpp | 6 ++- tests/auto/dbus/qdbusinterface/myobject.h | 7 ++-- .../qdbusinterface/qmyserver/qmyserver.cpp | 5 ++- .../qdbusinterface/tst_qdbusinterface.cpp | 22 ++++++----- .../qdbuslocalcalls/tst_qdbuslocalcalls.cpp | 14 ++++--- tests/auto/dbus/qdbusmarshall/common.h | 14 ++++++- tests/auto/dbus/qdbusmarshall/qpong/qpong.cpp | 6 ++- .../dbus/qdbusmarshall/tst_qdbusmarshall.cpp | 2 - .../qdbusmetaobject/tst_qdbusmetaobject.cpp | 12 ++++-- .../dbus/qdbusmetatype/tst_qdbusmetatype.cpp | 9 +++-- .../qdbuspendingcall/tst_qdbuspendingcall.cpp | 15 +++++--- .../tst_qdbuspendingreply.cpp | 13 +++++-- tests/auto/dbus/qdbusreply/tst_qdbusreply.cpp | 13 ++++--- .../tst_qdbusservicewatcher.cpp | 4 +- .../qdbusthreading/tst_qdbusthreading.cpp | 21 ++++++---- .../qdbusxmlparser/tst_qdbusxmlparser.cpp | 10 ++--- .../dbus/qdbusperformance/server/server.cpp | 2 +- .../dbus/qdbusperformance/serverobject.h | 3 +- .../qdbusperformance/tst_qdbusperformance.cpp | 7 +++- 51 files changed, 342 insertions(+), 238 deletions(-) diff --git a/examples/dbus/complexpingpong/complexping.cpp b/examples/dbus/complexpingpong/complexping.cpp index cf2535930de..8878083ee96 100644 --- a/examples/dbus/complexpingpong/complexping.cpp +++ b/examples/dbus/complexpingpong/complexping.cpp @@ -48,17 +48,18 @@ ** ****************************************************************************/ -#include - -#include -#include -#include -#include -#include - #include "ping-common.h" #include "complexping.h" +#include +#include +#include +#include +#include +#include + +#include + void Ping::start(const QString &name) { if (name != SERVICE_NAME) diff --git a/examples/dbus/complexpingpong/complexpong.cpp b/examples/dbus/complexpingpong/complexpong.cpp index c9cc78b3769..6b3430bc94f 100644 --- a/examples/dbus/complexpingpong/complexpong.cpp +++ b/examples/dbus/complexpingpong/complexpong.cpp @@ -48,16 +48,17 @@ ** ****************************************************************************/ -#include -#include - -#include -#include -#include - #include "ping-common.h" #include "complexpong.h" +#include +#include +#include +#include + +#include +#include + // the property QString Pong::value() const { diff --git a/examples/dbus/listnames/listnames.cpp b/examples/dbus/listnames/listnames.cpp index 50203da73de..fcd0e060a49 100644 --- a/examples/dbus/listnames/listnames.cpp +++ b/examples/dbus/listnames/listnames.cpp @@ -48,10 +48,13 @@ ** ****************************************************************************/ -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include void method1() { diff --git a/examples/dbus/pingpong/ping.cpp b/examples/dbus/pingpong/ping.cpp index e013a82eb27..64c1fe6bbf0 100644 --- a/examples/dbus/pingpong/ping.cpp +++ b/examples/dbus/pingpong/ping.cpp @@ -48,13 +48,15 @@ ** ****************************************************************************/ -#include - -#include -#include - #include "ping-common.h" +#include +#include +#include +#include + +#include + int main(int argc, char **argv) { QCoreApplication app(argc, argv); diff --git a/examples/dbus/pingpong/pong.cpp b/examples/dbus/pingpong/pong.cpp index e1e362f218f..37f62611428 100644 --- a/examples/dbus/pingpong/pong.cpp +++ b/examples/dbus/pingpong/pong.cpp @@ -48,16 +48,17 @@ ** ****************************************************************************/ -#include -#include - -#include -#include -#include - #include "ping-common.h" #include "pong.h" +#include +#include +#include +#include + +#include +#include + QString Pong::ping(const QString &arg) { QMetaObject::invokeMethod(QCoreApplication::instance(), "quit"); diff --git a/examples/dbus/remotecontrolledcar/controller/main.cpp b/examples/dbus/remotecontrolledcar/controller/main.cpp index 88edd13c1b0..4aeff8635e0 100644 --- a/examples/dbus/remotecontrolledcar/controller/main.cpp +++ b/examples/dbus/remotecontrolledcar/controller/main.cpp @@ -49,7 +49,7 @@ ****************************************************************************/ #include -#include + #include "controller.h" diff --git a/src/dbus/doc/snippets/qdbusextratypes/qdbusextratypes.cpp b/src/dbus/doc/snippets/qdbusextratypes/qdbusextratypes.cpp index a851e9f39f4..92b4be98295 100644 --- a/src/dbus/doc/snippets/qdbusextratypes/qdbusextratypes.cpp +++ b/src/dbus/doc/snippets/qdbusextratypes/qdbusextratypes.cpp @@ -49,7 +49,7 @@ ****************************************************************************/ #include -#include + static QVariant callMyDBusFunction() { return QVariant(); } diff --git a/src/gui/platform/unix/dbusmenu/qdbusmenuadaptor.cpp b/src/gui/platform/unix/dbusmenu/qdbusmenuadaptor.cpp index 9cdc1601e63..a9e508c6669 100644 --- a/src/gui/platform/unix/dbusmenu/qdbusmenuadaptor.cpp +++ b/src/gui/platform/unix/dbusmenu/qdbusmenuadaptor.cpp @@ -45,15 +45,17 @@ However it is maintained manually. */ -#include "qdbusmenuadaptor_p.h" -#include "qdbusplatformmenu_p.h" -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include QT_BEGIN_NAMESPACE diff --git a/src/gui/platform/unix/dbusmenu/qdbusmenuadaptor_p.h b/src/gui/platform/unix/dbusmenu/qdbusmenuadaptor_p.h index 6612f019a71..396f9d220f1 100644 --- a/src/gui/platform/unix/dbusmenu/qdbusmenuadaptor_p.h +++ b/src/gui/platform/unix/dbusmenu/qdbusmenuadaptor_p.h @@ -62,9 +62,10 @@ // We mean it. // -#include -#include -#include "qdbusmenutypes_p.h" +#include +#include + +#include QT_BEGIN_NAMESPACE diff --git a/src/gui/platform/unix/dbusmenu/qdbusmenuconnection.cpp b/src/gui/platform/unix/dbusmenu/qdbusmenuconnection.cpp index 429460f9e8c..7f7c3975e89 100644 --- a/src/gui/platform/unix/dbusmenu/qdbusmenuconnection.cpp +++ b/src/gui/platform/unix/dbusmenu/qdbusmenuconnection.cpp @@ -39,18 +39,19 @@ #include -#ifndef QT_NO_SYSTEMTRAYICON -#include "../dbustray/qdbustrayicon_p.h" -#endif -#include "qdbusmenuconnection_p.h" -#include "qdbusmenuadaptor_p.h" -#include "qdbusplatformmenu_p.h" +#include +#include +#include +#include +#include +#include -#include -#include -#include -#include -#include +#ifndef QT_NO_SYSTEMTRAYICON +#include +#endif +#include +#include +#include QT_BEGIN_NAMESPACE diff --git a/src/gui/platform/unix/dbustray/qdbustrayicon.cpp b/src/gui/platform/unix/dbustray/qdbustrayicon.cpp index 9d222ffef6f..1194e4ac664 100644 --- a/src/gui/platform/unix/dbustray/qdbustrayicon.cpp +++ b/src/gui/platform/unix/dbustray/qdbustrayicon.cpp @@ -41,23 +41,28 @@ #ifndef QT_NO_SYSTEMTRAYICON -#include -#include "qstatusnotifieritemadaptor_p.h" -#include -#include -#include "qxdgnotificationproxy_p.h" +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #include -#include -#include -#include -#include -#include -#include -#include #include #include -#include + +#include +#include +#include +#include +#include #include #include diff --git a/src/gui/platform/unix/dbustray/qstatusnotifieritemadaptor_p.h b/src/gui/platform/unix/dbustray/qstatusnotifieritemadaptor_p.h index f2bb156b1d2..01722348bb8 100644 --- a/src/gui/platform/unix/dbustray/qstatusnotifieritemadaptor_p.h +++ b/src/gui/platform/unix/dbustray/qstatusnotifieritemadaptor_p.h @@ -62,14 +62,14 @@ // We mean it. // -#include +#include QT_REQUIRE_CONFIG(systemtrayicon); -#include -#include +#include +#include -#include "qdbustraytypes_p.h" +#include QT_BEGIN_NAMESPACE class QDBusTrayIcon; diff --git a/src/gui/platform/unix/dbustray/qxdgnotificationproxy_p.h b/src/gui/platform/unix/dbustray/qxdgnotificationproxy_p.h index 495208f873a..eb916e75124 100644 --- a/src/gui/platform/unix/dbustray/qxdgnotificationproxy_p.h +++ b/src/gui/platform/unix/dbustray/qxdgnotificationproxy_p.h @@ -62,15 +62,17 @@ // We mean it. // -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include QT_BEGIN_NAMESPACE diff --git a/src/gui/platform/unix/qgenericunixthemes.cpp b/src/gui/platform/unix/qgenericunixthemes.cpp index 85a1d28999c..86f2a266eaf 100644 --- a/src/gui/platform/unix/qgenericunixthemes.cpp +++ b/src/gui/platform/unix/qgenericunixthemes.cpp @@ -39,32 +39,34 @@ #include "qgenericunixthemes_p.h" -#include "qpa/qplatformtheme_p.h" -#include "qpa/qplatformfontdatabase.h" // lcQpaFonts - -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #if QT_CONFIG(mimetype) -#include +#include #endif -#include #if QT_CONFIG(settings) -#include +#include #endif -#include -#include -#include -#include + +#include // lcQpaFonts #include #include #include +#include + +#include #ifndef QT_NO_DBUS +#include #include #include #endif diff --git a/src/plugins/platforminputcontexts/ibus/qibusinputcontextproxy.h b/src/plugins/platforminputcontexts/ibus/qibusinputcontextproxy.h index 396a213aaa6..3d11706c06e 100644 --- a/src/plugins/platforminputcontexts/ibus/qibusinputcontextproxy.h +++ b/src/plugins/platforminputcontexts/ibus/qibusinputcontextproxy.h @@ -11,14 +11,16 @@ #ifndef QIBUSINPUTCONTEXTPROXY_H_1394889529 #define QIBUSINPUTCONTEXTPROXY_H_1394889529 -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + /* * Proxy class for interface org.freedesktop.IBus.InputContext diff --git a/src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp b/src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp index 7f8a0ea47b0..32f9a834e0c 100644 --- a/src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp +++ b/src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp @@ -38,30 +38,33 @@ ****************************************************************************/ #include "qibusplatforminputcontext.h" -#include +#include #include #include +#include +#include +#include +#include #include -#include -#include - -#include -#include -#include - -#include - -#include +#include +#include +#include #include "qibusproxy.h" #include "qibusproxyportal.h" #include "qibusinputcontextproxy.h" #include "qibustypes.h" +#include +#include +#include + +#include +#include + #include #include -#include #ifndef IBUS_RELEASE_MASK #define IBUS_RELEASE_MASK (1 << 30) diff --git a/src/plugins/platforminputcontexts/ibus/qibusproxy.cpp b/src/plugins/platforminputcontexts/ibus/qibusproxy.cpp index 6b46e106ab4..9f6fbf43923 100644 --- a/src/plugins/platforminputcontexts/ibus/qibusproxy.cpp +++ b/src/plugins/platforminputcontexts/ibus/qibusproxy.cpp @@ -13,6 +13,8 @@ #include "qibusproxy.h" +#include + /* * Implementation of interface class QIBusProxy */ diff --git a/src/plugins/platforminputcontexts/ibus/qibusproxy.h b/src/plugins/platforminputcontexts/ibus/qibusproxy.h index c9876deebf2..c66e9006647 100644 --- a/src/plugins/platforminputcontexts/ibus/qibusproxy.h +++ b/src/plugins/platforminputcontexts/ibus/qibusproxy.h @@ -11,14 +11,15 @@ #ifndef QIBUSPROXY_H_1308831142 #define QIBUSPROXY_H_1308831142 -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #include "qibustypes.h" diff --git a/src/plugins/platforminputcontexts/ibus/qibusproxyportal.h b/src/plugins/platforminputcontexts/ibus/qibusproxyportal.h index bdd1d9c3956..4b921db8142 100644 --- a/src/plugins/platforminputcontexts/ibus/qibusproxyportal.h +++ b/src/plugins/platforminputcontexts/ibus/qibusproxyportal.h @@ -11,14 +11,15 @@ #ifndef QIBUSPROXYPORTAL_H #define QIBUSPROXYPORTAL_H -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include /* * Proxy class for interface org.freedesktop.IBus.Portal diff --git a/src/plugins/platforminputcontexts/ibus/qibustypes.cpp b/src/plugins/platforminputcontexts/ibus/qibustypes.cpp index 443df271a8c..eb1c0e3e06f 100644 --- a/src/plugins/platforminputcontexts/ibus/qibustypes.cpp +++ b/src/plugins/platforminputcontexts/ibus/qibustypes.cpp @@ -38,7 +38,7 @@ ****************************************************************************/ #include "qibustypes.h" -#include + #include QT_BEGIN_NAMESPACE diff --git a/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportalfiledialog.cpp b/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportalfiledialog.cpp index c4dc2da6239..ec153f6e0cd 100644 --- a/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportalfiledialog.cpp +++ b/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportalfiledialog.cpp @@ -39,21 +39,21 @@ #include "qxdgdesktopportalfiledialog_p.h" -#include - -#include #include #include #include #include #include +#include +#include #include #include #include #include #include #include +#include QT_BEGIN_NAMESPACE diff --git a/tests/auto/dbus/qdbusabstractadaptor/myobject.h b/tests/auto/dbus/qdbusabstractadaptor/myobject.h index a0c5d5c1299..768e817043f 100644 --- a/tests/auto/dbus/qdbusabstractadaptor/myobject.h +++ b/tests/auto/dbus/qdbusabstractadaptor/myobject.h @@ -29,8 +29,11 @@ #ifndef MYOBJECT_H #define MYOBJECT_H -#include -#include +#include +#include +#include +#include +#include extern const char *slotSpy; extern QString valueSpy; diff --git a/tests/auto/dbus/qdbusabstractadaptor/qmyserver/qmyserver.cpp b/tests/auto/dbus/qdbusabstractadaptor/qmyserver/qmyserver.cpp index 3e79fb77f4d..a452d299b44 100644 --- a/tests/auto/dbus/qdbusabstractadaptor/qmyserver/qmyserver.cpp +++ b/tests/auto/dbus/qdbusabstractadaptor/qmyserver/qmyserver.cpp @@ -26,8 +26,13 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include + +#include +#include +#include +#include +#include +#include #include "../myobject.h" diff --git a/tests/auto/dbus/qdbusabstractadaptor/tst_qdbusabstractadaptor.cpp b/tests/auto/dbus/qdbusabstractadaptor/tst_qdbusabstractadaptor.cpp index fd74f45336f..23fe3ff51ab 100644 --- a/tests/auto/dbus/qdbusabstractadaptor/tst_qdbusabstractadaptor.cpp +++ b/tests/auto/dbus/qdbusabstractadaptor/tst_qdbusabstractadaptor.cpp @@ -26,12 +26,15 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include #include - -#include +#include +#include +#include +#include +#include +#include +#include #include "../qdbusmarshall/common.h" #include "myobject.h" diff --git a/tests/auto/dbus/qdbusabstractinterface/interface.h b/tests/auto/dbus/qdbusabstractinterface/interface.h index 209c7d359cd..f9e6c0e0283 100644 --- a/tests/auto/dbus/qdbusabstractinterface/interface.h +++ b/tests/auto/dbus/qdbusabstractinterface/interface.h @@ -29,9 +29,9 @@ #ifndef INTERFACE_H #define INTERFACE_H -#include -#include -#include +#include +#include +#include struct RegisteredType { diff --git a/tests/auto/dbus/qdbusabstractinterface/qpinger/qpinger.cpp b/tests/auto/dbus/qdbusabstractinterface/qpinger/qpinger.cpp index 7f098aeb36d..2ff7d313325 100644 --- a/tests/auto/dbus/qdbusabstractinterface/qpinger/qpinger.cpp +++ b/tests/auto/dbus/qdbusabstractinterface/qpinger/qpinger.cpp @@ -26,8 +26,15 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include + +#include + +#include +#include +#include +#include +#include + #include "../interface.h" static const char serviceName[] = "org.qtproject.autotests.qpinger"; diff --git a/tests/auto/dbus/qdbusabstractinterface/tst_qdbusabstractinterface.cpp b/tests/auto/dbus/qdbusabstractinterface/tst_qdbusabstractinterface.cpp index 613baaab410..7cdf9dfe9c5 100644 --- a/tests/auto/dbus/qdbusabstractinterface/tst_qdbusabstractinterface.cpp +++ b/tests/auto/dbus/qdbusabstractinterface/tst_qdbusabstractinterface.cpp @@ -26,15 +26,18 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include -#include #include #include +#include +#include +#include #include - -#include +#include +#include +#include +#include +#include #include "interface.h" #include "pinger_interface.h" diff --git a/tests/auto/dbus/qdbusconnection/tst_qdbusconnection.cpp b/tests/auto/dbus/qdbusconnection/tst_qdbusconnection.cpp index 314a23f9877..cd6288ee34c 100644 --- a/tests/auto/dbus/qdbusconnection/tst_qdbusconnection.cpp +++ b/tests/auto/dbus/qdbusconnection/tst_qdbusconnection.cpp @@ -29,12 +29,14 @@ #include "tst_qdbusconnection.h" -#include -#include - #include - -#include +#include +#include +#include +#include +#include +#include +#include #ifdef Q_OS_UNIX # include diff --git a/tests/auto/dbus/qdbusconnection/tst_qdbusconnection.h b/tests/auto/dbus/qdbusconnection/tst_qdbusconnection.h index d87d0e3773d..a2e80149bc4 100644 --- a/tests/auto/dbus/qdbusconnection/tst_qdbusconnection.h +++ b/tests/auto/dbus/qdbusconnection/tst_qdbusconnection.h @@ -31,9 +31,12 @@ #define TST_QDBUSCONNECTION_H #include -#include #include #include +#include +#include +#include +#include class BaseObject: public QObject { diff --git a/tests/auto/dbus/qdbusconnection_delayed/tst_qdbusconnection_delayed.cpp b/tests/auto/dbus/qdbusconnection_delayed/tst_qdbusconnection_delayed.cpp index a150451d34b..b93ebbc4cd4 100644 --- a/tests/auto/dbus/qdbusconnection_delayed/tst_qdbusconnection_delayed.cpp +++ b/tests/auto/dbus/qdbusconnection_delayed/tst_qdbusconnection_delayed.cpp @@ -26,9 +26,10 @@ ** ****************************************************************************/ -#include #include #include +#include +#include #ifdef Q_OS_WIN # include diff --git a/tests/auto/dbus/qdbusconnection_no_bus/tst_qdbusconnection_no_bus.cpp b/tests/auto/dbus/qdbusconnection_no_bus/tst_qdbusconnection_no_bus.cpp index 845360c93d9..715b94d404b 100644 --- a/tests/auto/dbus/qdbusconnection_no_bus/tst_qdbusconnection_no_bus.cpp +++ b/tests/auto/dbus/qdbusconnection_no_bus/tst_qdbusconnection_no_bus.cpp @@ -25,11 +25,11 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include #include -#include +#include +#include +#include #include diff --git a/tests/auto/dbus/qdbusconnection_no_libdbus/tst_qdbusconnection_no_libdbus.cpp b/tests/auto/dbus/qdbusconnection_no_libdbus/tst_qdbusconnection_no_libdbus.cpp index cf306a7eb4b..946a9a2d97b 100644 --- a/tests/auto/dbus/qdbusconnection_no_libdbus/tst_qdbusconnection_no_libdbus.cpp +++ b/tests/auto/dbus/qdbusconnection_no_libdbus/tst_qdbusconnection_no_libdbus.cpp @@ -29,7 +29,7 @@ #include #include -#include + #include diff --git a/tests/auto/dbus/qdbuscontext/tst_qdbuscontext.cpp b/tests/auto/dbus/qdbuscontext/tst_qdbuscontext.cpp index af1c64336dc..87e2c8a1c16 100644 --- a/tests/auto/dbus/qdbuscontext/tst_qdbuscontext.cpp +++ b/tests/auto/dbus/qdbuscontext/tst_qdbuscontext.cpp @@ -25,8 +25,12 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include + #include +#include +#include +#include +#include const char errorName[] = "org.qtproject.tst_QDBusContext.Error"; const char errorMsg[] = "A generic error"; diff --git a/tests/auto/dbus/qdbusinterface/myobject.h b/tests/auto/dbus/qdbusinterface/myobject.h index 32da7348f2b..e6f6d4a5059 100644 --- a/tests/auto/dbus/qdbusinterface/myobject.h +++ b/tests/auto/dbus/qdbusinterface/myobject.h @@ -29,9 +29,10 @@ #ifndef MYOBJECT_H #define MYOBJECT_H -#include -#include - +#include +#include +#include +#include class MyObject: public QObject, protected QDBusContext { diff --git a/tests/auto/dbus/qdbusinterface/qmyserver/qmyserver.cpp b/tests/auto/dbus/qdbusinterface/qmyserver/qmyserver.cpp index 53eb9585f8a..f7a935b1bad 100644 --- a/tests/auto/dbus/qdbusinterface/qmyserver/qmyserver.cpp +++ b/tests/auto/dbus/qdbusinterface/qmyserver/qmyserver.cpp @@ -26,8 +26,9 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include + +#include +#include #include "../myobject.h" diff --git a/tests/auto/dbus/qdbusinterface/tst_qdbusinterface.cpp b/tests/auto/dbus/qdbusinterface/tst_qdbusinterface.cpp index 8ed8762987b..0d619e9c91e 100644 --- a/tests/auto/dbus/qdbusinterface/tst_qdbusinterface.cpp +++ b/tests/auto/dbus/qdbusinterface/tst_qdbusinterface.cpp @@ -25,18 +25,22 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -/* -*- C++ -*- - */ -#include -#include #include +#include #include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include + #include "../qdbusmarshall/common.h" #include "myobject.h" diff --git a/tests/auto/dbus/qdbuslocalcalls/tst_qdbuslocalcalls.cpp b/tests/auto/dbus/qdbuslocalcalls/tst_qdbuslocalcalls.cpp index 705e1e065d7..5caea5b14d5 100644 --- a/tests/auto/dbus/qdbuslocalcalls/tst_qdbuslocalcalls.cpp +++ b/tests/auto/dbus/qdbuslocalcalls/tst_qdbuslocalcalls.cpp @@ -25,14 +25,16 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include -#include -#include + #include #include -#include - +#include +#include +#include +#include +#include +#include +#include class tst_QDBusLocalCalls: public QObject { diff --git a/tests/auto/dbus/qdbusmarshall/common.h b/tests/auto/dbus/qdbusmarshall/common.h index 3dfe3e39bbc..9bdc1ebe66a 100644 --- a/tests/auto/dbus/qdbusmarshall/common.h +++ b/tests/auto/dbus/qdbusmarshall/common.h @@ -25,8 +25,18 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include // qIsNan -#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #ifdef Q_OS_UNIX # include diff --git a/tests/auto/dbus/qdbusmarshall/qpong/qpong.cpp b/tests/auto/dbus/qdbusmarshall/qpong/qpong.cpp index cfcd51da7df..7333f5961d9 100644 --- a/tests/auto/dbus/qdbusmarshall/qpong/qpong.cpp +++ b/tests/auto/dbus/qdbusmarshall/qpong/qpong.cpp @@ -25,8 +25,10 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include + +#include +#include +#include static const char serviceName[] = "org.qtproject.autotests.qpong"; static const char objectPath[] = "/org/qtproject/qpong"; diff --git a/tests/auto/dbus/qdbusmarshall/tst_qdbusmarshall.cpp b/tests/auto/dbus/qdbusmarshall/tst_qdbusmarshall.cpp index 9078ef02ab3..c6928ca28d1 100644 --- a/tests/auto/dbus/qdbusmarshall/tst_qdbusmarshall.cpp +++ b/tests/auto/dbus/qdbusmarshall/tst_qdbusmarshall.cpp @@ -30,8 +30,6 @@ #include #include -#include - #include "common.h" #include diff --git a/tests/auto/dbus/qdbusmetaobject/tst_qdbusmetaobject.cpp b/tests/auto/dbus/qdbusmetaobject/tst_qdbusmetaobject.cpp index 059b8cd4836..3743a8ad074 100644 --- a/tests/auto/dbus/qdbusmetaobject/tst_qdbusmetaobject.cpp +++ b/tests/auto/dbus/qdbusmetaobject/tst_qdbusmetaobject.cpp @@ -25,11 +25,15 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include + #include class tst_QDBusMetaObject: public QObject diff --git a/tests/auto/dbus/qdbusmetatype/tst_qdbusmetatype.cpp b/tests/auto/dbus/qdbusmetatype/tst_qdbusmetatype.cpp index 7bc6637a08e..6735bdaf807 100644 --- a/tests/auto/dbus/qdbusmetatype/tst_qdbusmetatype.cpp +++ b/tests/auto/dbus/qdbusmetatype/tst_qdbusmetatype.cpp @@ -25,11 +25,12 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include -#include -#include +#include +#include +#include +#include +#include class tst_QDBusMetaType: public QObject { diff --git a/tests/auto/dbus/qdbuspendingcall/tst_qdbuspendingcall.cpp b/tests/auto/dbus/qdbuspendingcall/tst_qdbuspendingcall.cpp index 474f9b91198..0698c4591f0 100644 --- a/tests/auto/dbus/qdbuspendingcall/tst_qdbuspendingcall.cpp +++ b/tests/auto/dbus/qdbuspendingcall/tst_qdbuspendingcall.cpp @@ -26,13 +26,18 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include -#include -#include + #include #include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #define TEST_INTERFACE_NAME "org.qtproject.QtDBus.MyObject" diff --git a/tests/auto/dbus/qdbuspendingreply/tst_qdbuspendingreply.cpp b/tests/auto/dbus/qdbuspendingreply/tst_qdbuspendingreply.cpp index 647749da8e1..21563799d4e 100644 --- a/tests/auto/dbus/qdbuspendingreply/tst_qdbuspendingreply.cpp +++ b/tests/auto/dbus/qdbuspendingreply/tst_qdbuspendingreply.cpp @@ -25,11 +25,16 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include -#include + #include -#include +#include +#include +#include +#include +#include +#include +#include +#include typedef QMap IntStringMap; Q_DECLARE_METATYPE(IntStringMap) diff --git a/tests/auto/dbus/qdbusreply/tst_qdbusreply.cpp b/tests/auto/dbus/qdbusreply/tst_qdbusreply.cpp index c68f0e4300e..0d217dae697 100644 --- a/tests/auto/dbus/qdbusreply/tst_qdbusreply.cpp +++ b/tests/auto/dbus/qdbusreply/tst_qdbusreply.cpp @@ -25,13 +25,16 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include -#include #include - -#include +#include +#include +#include +#include +#include +#include +#include +#include typedef QMap IntStringMap; Q_DECLARE_METATYPE(IntStringMap) diff --git a/tests/auto/dbus/qdbusservicewatcher/tst_qdbusservicewatcher.cpp b/tests/auto/dbus/qdbusservicewatcher/tst_qdbusservicewatcher.cpp index d1ebabdad32..d2c3a830ca6 100644 --- a/tests/auto/dbus/qdbusservicewatcher/tst_qdbusservicewatcher.cpp +++ b/tests/auto/dbus/qdbusservicewatcher/tst_qdbusservicewatcher.cpp @@ -27,11 +27,11 @@ ** ****************************************************************************/ -#include -#include #include #include #include +#include +#include class tst_QDBusServiceWatcher: public QObject { diff --git a/tests/auto/dbus/qdbusthreading/tst_qdbusthreading.cpp b/tests/auto/dbus/qdbusthreading/tst_qdbusthreading.cpp index 9c12dc82353..3e1ec4242b6 100644 --- a/tests/auto/dbus/qdbusthreading/tst_qdbusthreading.cpp +++ b/tests/auto/dbus/qdbusthreading/tst_qdbusthreading.cpp @@ -25,16 +25,21 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ + #include #include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include class Thread : public QThread { diff --git a/tests/auto/dbus/qdbusxmlparser/tst_qdbusxmlparser.cpp b/tests/auto/dbus/qdbusxmlparser/tst_qdbusxmlparser.cpp index 2867b645959..e935934fa16 100644 --- a/tests/auto/dbus/qdbusxmlparser/tst_qdbusxmlparser.cpp +++ b/tests/auto/dbus/qdbusxmlparser/tst_qdbusxmlparser.cpp @@ -25,13 +25,11 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -/* -*- C++ -*- - */ -#include -#include + +#include +#include +#include #include -#include -#include #define USE_PRIVATE_CODE #include "../qdbusmarshall/common.h" diff --git a/tests/benchmarks/dbus/qdbusperformance/server/server.cpp b/tests/benchmarks/dbus/qdbusperformance/server/server.cpp index 6f0bca8bb1f..3831a62f716 100644 --- a/tests/benchmarks/dbus/qdbusperformance/server/server.cpp +++ b/tests/benchmarks/dbus/qdbusperformance/server/server.cpp @@ -26,7 +26,7 @@ ** ****************************************************************************/ #include -#include + #include "../serverobject.h" diff --git a/tests/benchmarks/dbus/qdbusperformance/serverobject.h b/tests/benchmarks/dbus/qdbusperformance/serverobject.h index f3c2d96f025..b7ef2991c2b 100644 --- a/tests/benchmarks/dbus/qdbusperformance/serverobject.h +++ b/tests/benchmarks/dbus/qdbusperformance/serverobject.h @@ -31,7 +31,8 @@ #define SERVEROBJECT_H #include -#include +#include +#include class ServerObject: public QObject { diff --git a/tests/benchmarks/dbus/qdbusperformance/tst_qdbusperformance.cpp b/tests/benchmarks/dbus/qdbusperformance/tst_qdbusperformance.cpp index 60d6ba88cbe..1f76c413be2 100644 --- a/tests/benchmarks/dbus/qdbusperformance/tst_qdbusperformance.cpp +++ b/tests/benchmarks/dbus/qdbusperformance/tst_qdbusperformance.cpp @@ -25,10 +25,13 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include + #include #include -#include +#include +#include +#include +#include #include "./serverobject.h"