From 9d705d90d0dac4c2e66eb4b7f11c2a1c37bd81d1 Mon Sep 17 00:00:00 2001 From: Luca Di Sera Date: Tue, 17 Jan 2023 13:25:25 +0100 Subject: [PATCH] Doc: Remove stale documentation in "qproperty.cpp" "src/corelib/kernel/qproperty.cpp" documents assignment operators over `QPropertyBinding` for `QProperty` and `QPropertyAlias`. Those operators were removed in 638df6138e7acecc2d3b6aad0771e2d81355f2d2 and are thus stale. Similarly, an assignment operator for `QPropertyAlias` over a `T&&` is documented albeit it was removed in 927647cd032cd2e43bae3184b879586849ffee50. Due an incorrect implementation of QDoc, which has now been removed, with regards to identifying copy/move assignment operators, and the more superficial and incorrect way in which QDoc binds those kind of elements to the clang AST, QDoc was unable to report the lack of a binding declaration for those elements that were removed, producing incorrect documentation instead. As of the latest changes to QDoc this will correctly generate a warning. To avoid the addition of new warnings and remove stale and incorrect documentation, the document blocks were removed from the file. Change-Id: I30e20f26d4c44e4589abf40546d8ebaa4e869638 Reviewed-by: Fabian Kosmale --- src/corelib/kernel/qproperty.cpp | 29 ----------------------------- 1 file changed, 29 deletions(-) diff --git a/src/corelib/kernel/qproperty.cpp b/src/corelib/kernel/qproperty.cpp index 742d2c5f409..2bace6a0e2a 100644 --- a/src/corelib/kernel/qproperty.cpp +++ b/src/corelib/kernel/qproperty.cpp @@ -1325,15 +1325,6 @@ QString QPropertyBindingError::description() const Assigns \a newValue to this property and returns a reference to this QProperty. */ -/*! - \fn template QProperty &QProperty::operator=(const QPropertyBinding &newBinding) - - Associates the value of this property with the provided \a newBinding - expression and returns a reference to this property. The property's value is - set to the result of evaluating the new binding. Whenever a dependency of the - binding changes, the binding will be re-evaluated. -*/ - /*! \fn template QPropertyBinding QProperty::setBinding(const QPropertyBinding &newBinding) @@ -1998,26 +1989,6 @@ QString QPropertyBindingError::description() const QPropertyAlias. */ -/*! - \fn template QPropertyAlias &QPropertyAlias::operator=(T &&newValue) - \overload - - Assigns \a newValue to the aliased property and returns a reference to this - QPropertyAlias. -*/ - -/*! - \fn template QPropertyAlias &QPropertyAlias::operator=(const QPropertyBinding &newBinding) - \overload - - Associates the value of the aliased property with the provided \a newBinding - expression and returns a reference to this alias. The property's value is set - to the result of evaluating the new binding. Whenever a dependency of the - binding changes, the binding will be re-evaluated, and the property's value - gets updated accordingly. - -*/ - /*! \fn template QPropertyBinding QPropertyAlias::setBinding(const QPropertyBinding &newBinding)