1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change for QTRY_VERIFY in flaky auto test focusNextOnHide()

Browse Source 
Auto test tst_QAbstractItemView::focusNextOnHide() is flaky where
QVERIFY(table.hasFocus()) sometimes return false where it should be
true.

Modify QVERIFY for QTRY_VERIFY to give the necessary time to the XCB
thread to proceed.

Removes the flakiness when testing on OpenSuse 15.5

Change-Id: I83690e7c851430c040a57713516a5df990a89c32
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
This commit is contained in:
Frédéric Lefebvre 2024-11-07 09:46:05 +01:00
parent 0534a566a7
commit 9d6fdad624
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/auto/widgets/itemviews/qabstractitemview/tst_qabstractitemview.cpp
View File

@ -3556,7 +3556,7 @@ void tst_QAbstractItemView::focusNextOnHide()
widget.show();
QVERIFY(QTest::qWaitForWindowExposed(&widget));
QVERIFY(table.hasFocus());
QTRY_VERIFY(table.hasFocus());
QCOMPARE(table.currentIndex(), table.model()->index(0, 0));
QTest::keyPress(&table, Qt::Key_Tab);
QCOMPARE(table.currentIndex(), table.model()->index(0, 1));