1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Specialize qMulOverflow<2>(n) as qAddOverflow(n, n)

Browse Source 
Addition is always more efficient than multiplication.

Task-number: QTBUG-104972
Change-Id: Ib945e7df88562a2f4aea00aa319ff837191b8df2
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
(cherry picked from commit 4b5b87c27b803c5bf0fed96c381c5e343b28d419)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Marc Mutz 2022-09-08 16:46:13 +02:00 committed by Qt Cherry-pick Bot
parent 40e844918a
commit 9bcb73af22
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/corelib/global/qnumeric.h
View File

@ -312,6 +312,8 @@ template <typename T, T V2> bool qMulOverflow(T v1, std::integral_constant<T, V2
template <auto V2, typename T> bool qMulOverflow(T v1, T *r) template <auto V2, typename T> bool qMulOverflow(T v1, T *r)
{ {
if constexpr (V2 == 2)
return qAddOverflow(v1, v1, r);
return qMulOverflow(v1, std::integral_constant<T, V2>{}, r); return qMulOverflow(v1, std::integral_constant<T, V2>{}, r);
} }