1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add QTestPrivate::ensurePositionTopLeft() for reliable positioning

Browse Source 
Implement ensurePositionTopLeft() to set a window's position
to the available top-left corner and verify that it is correctly
positioned.

Incorrect updates to window.position and window.framePosition have
been identified as one of the main sources of flakiness on
Opensuse. This test function addresses this issue and improves test
reliablity.

Task-number: QTQAINFRA-7050
Change-Id: I946f74c7d2c1db9cfe4fec7db272e12876b3ed43
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
(cherry picked from commit 7929852c1d39e12b7c586b5c6d257c9df27c01df)
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
This commit is contained in:
Frédéric Lefebvre 2025-03-19 13:11:04 +01:00 committed by Axel Spoerl
parent 7bf07cc12c
commit 9b9bd00c2b
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/testlib/qtesthelpers_p.h
View File

@ -24,6 +24,7 @@
#ifdef QT_GUI_LIB
#include <QtGui/QGuiApplication>
#include <QtGui/QScreen>
#include <QtGui/QWindow>
#endif
#ifdef QT_WIDGETS_LIB
@ -91,6 +92,24 @@ static inline void androidCompatibleShow(QWidget *widget)
}
#endif // QT_WIDGETS_LIB
#ifdef QT_GUI_LIB
bool ensurePositionTopLeft(QWindow *window)
{
const QPoint availableTopLeft = QGuiApplication::primaryScreen()->availableGeometry().topLeft();
window->setFramePosition(availableTopLeft);
bool positionCorrect = true;
if (!window->flags().testFlag(Qt::FramelessWindowHint))
positionCorrect = QTest::qWaitFor([&]{ return window->framePosition() != window->position() ;});
const bool positionUpdated = QTest::qWaitFor([&]{ return window->framePosition() == availableTopLeft ;});
if (!positionUpdated)
positionCorrect = false;
return positionCorrect;
}
#endif
#ifdef QT_NETWORK_LIB
inline bool isSecureTransportBlockingTest()
{

1
tests/auto/gui/kernel/qwindow/CMakeLists.txt
View File

@ -18,6 +18,7 @@ qt_internal_add_test(tst_qwindow
Qt::CorePrivate
Qt::Gui
Qt::GuiPrivate
Qt::TestPrivate
)
if(APPLE OR WIN32 OR QT_FEATURE_xcb)