QTest::CrashHandler: move windowsFaultHandler() out of the class
It accesses no members (there are none!), which further simplifies the header. Change-Id: Ic1251d8b56dc6cfeb136fffd7baf4d8bc7143750 Reviewed-by: Ahmad Samir <a.samirh78@gmail.com> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
This commit is contained in:
parent
fc7c5c0a2b
commit
9a66c7c1b9
@ -30,7 +30,6 @@
|
||||
|
||||
#ifdef Q_OS_WIN
|
||||
#include <iostream>
|
||||
#include <qt_windows.h> // for Sleep
|
||||
#endif
|
||||
|
||||
QT_BEGIN_NAMESPACE
|
||||
@ -88,9 +87,6 @@ namespace CrashHandler {
|
||||
{
|
||||
public:
|
||||
WindowsFaultHandler();
|
||||
|
||||
private:
|
||||
static LONG WINAPI windowsFaultHandler(struct _EXCEPTION_POINTERS *exInfo);
|
||||
};
|
||||
using FatalSignalHandler = WindowsFaultHandler;
|
||||
#elif defined(Q_OS_UNIX) && !defined(Q_OS_WASM)
|
||||
|
@ -16,6 +16,7 @@
|
||||
#if !defined(Q_CC_MINGW) || (defined(Q_CC_MINGW) && defined(__MINGW64_VERSION_MAJOR))
|
||||
# include <crtdbg.h>
|
||||
#endif
|
||||
#include <qt_windows.h>
|
||||
|
||||
QT_BEGIN_NAMESPACE
|
||||
|
||||
@ -168,6 +169,8 @@ DebugSymbolResolver::Symbol DebugSymbolResolver::resolveSymbol(DWORD64 address)
|
||||
}
|
||||
} // unnamed namespace
|
||||
|
||||
static LONG WINAPI windowsFaultHandler(struct _EXCEPTION_POINTERS *exInfo);
|
||||
|
||||
WindowsFaultHandler::WindowsFaultHandler()
|
||||
{
|
||||
# if !defined(Q_CC_MINGW)
|
||||
@ -177,7 +180,7 @@ WindowsFaultHandler::WindowsFaultHandler()
|
||||
SetUnhandledExceptionFilter(windowsFaultHandler);
|
||||
}
|
||||
|
||||
LONG WINAPI WindowsFaultHandler::windowsFaultHandler(struct _EXCEPTION_POINTERS *exInfo)
|
||||
static LONG WINAPI windowsFaultHandler(struct _EXCEPTION_POINTERS *exInfo)
|
||||
{
|
||||
enum { maxStackFrames = 100 };
|
||||
char appName[MAX_PATH];
|
||||
|
Loading…
x
Reference in New Issue
Block a user