diff --git a/src/corelib/kernel/qcoreapplication.cpp b/src/corelib/kernel/qcoreapplication.cpp index 79a9aac4247..5d7f71d120e 100644 --- a/src/corelib/kernel/qcoreapplication.cpp +++ b/src/corelib/kernel/qcoreapplication.cpp @@ -434,8 +434,8 @@ QCoreApplicationPrivate::QCoreApplicationPrivate(int &aargc, char **aargv) #if defined(Q_OS_WIN) if (!isArgvModified(argc, argv)) { origArgc = argc; - origArgv = new char *[argc]; - std::copy(argv, argv + argc, QT_MAKE_CHECKED_ARRAY_ITERATOR(origArgv, argc)); + origArgv = q20::make_unique_for_overwrite(argc); + std::copy(argv, argv + argc, origArgv.get()); } #endif // Q_OS_WIN @@ -459,7 +459,6 @@ QCoreApplicationPrivate::~QCoreApplicationPrivate() cleanupThreadData(); #endif #if defined(Q_OS_WIN) && !defined(QT_BOOTSTRAPPED) - delete [] origArgv; cleanupDebuggingConsole(); #endif QCoreApplicationPrivate::clearApplicationFilePath(); diff --git a/src/corelib/kernel/qcoreapplication_p.h b/src/corelib/kernel/qcoreapplication_p.h index d7223ffeb1d..0e007e55756 100644 --- a/src/corelib/kernel/qcoreapplication_p.h +++ b/src/corelib/kernel/qcoreapplication_p.h @@ -125,8 +125,10 @@ public: int &argc; char **argv; #if defined(Q_OS_WIN) + // store unmodified arguments for QCoreApplication::arguments() int origArgc = 0; - char **origArgv = nullptr; // store unmodified arguments for QCoreApplication::arguments() + std::unique_ptr origArgv; + bool consoleAllocated = false; #endif void appendApplicationPathToLibraryPaths(void);