1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tst_QRestAccessManager: fix signature of server handlers

Browse Source 
HttpTestServer::Handler is declared to take the first argument by
reference to const, not by value, so use the same parameter passing
for the lambdas passed to setHandler().

Avoids copying the (rather large) argument when invoked through the
std::function wrapper, and silences clazy-function-args-by-ref.

Change-Id: I726d0b98a7fcb3b1b33c5bde203035f593c39bdd
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
(cherry picked from commit 5b6c6dab632a32a09963453b08731e9e33334e9a)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Marc Mutz 2024-04-18 08:59:43 +02:00 committed by Qt Cherry-pick Bot
parent 2581730d88
commit 963e886c6f
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/auto/network/access/qrestaccessmanager/tst_qrestaccessmanager.cpp
View File

@ -107,7 +107,7 @@ void tst_QRestAccessManager::requests()
HttpData serverSideRequest; // The request data the server received
HttpData serverSideResponse; // The response data the server responds with
serverSideResponse.status = 200;
server.setHandler([&](HttpData request, HttpData &response, ResponseControl&) {
server.setHandler([&](const HttpData &request, HttpData &response, ResponseControl&) {
serverSideRequest = request;
response = serverSideResponse;
@ -471,7 +471,7 @@ void tst_QRestAccessManager::errors()
QNetworkRequest request(server.url());
HttpData serverSideResponse; // The response data the server responds with
server.setHandler([&](HttpData, HttpData &response, ResponseControl &) {
server.setHandler([&](const HttpData &, HttpData &response, ResponseControl &) {
response = serverSideResponse;
});
@ -538,7 +538,7 @@ void tst_QRestAccessManager::body()
HttpData serverSideRequest; // The request data the server received
HttpData serverSideResponse; // The response data the server responds with
server.setHandler([&](HttpData request, HttpData &response, ResponseControl&) {
server.setHandler([&](const HttpData &request, HttpData &response, ResponseControl&) {
serverSideRequest = request;
response = serverSideResponse;
});
@ -599,7 +599,7 @@ void tst_QRestAccessManager::json()
HttpData serverSideRequest; // The request data the server received
HttpData serverSideResponse; // The response data the server responds with
serverSideResponse.status = 200;
server.setHandler([&](HttpData request, HttpData &response, ResponseControl&) {
server.setHandler([&](const HttpData &request, HttpData &response, ResponseControl&) {
serverSideRequest = request;
response = serverSideResponse;
});
@ -707,7 +707,7 @@ void tst_QRestAccessManager::text()
HttpData serverSideRequest; // The request data the server received
HttpData serverSideResponse; // The response data the server responds with
serverSideResponse.status = 200;
server.setHandler([&](HttpData request, HttpData &response, ResponseControl&) {
server.setHandler([&](const HttpData &request, HttpData &response, ResponseControl&) {
serverSideRequest = request;
response = serverSideResponse;
});
@ -791,7 +791,7 @@ void tst_QRestAccessManager::textStreaming()
serverSideResponse.body = encUTF8(expectedData);
serverSideResponse.status = 200;
server.setHandler([&](HttpData, HttpData &response, ResponseControl &control) {
server.setHandler([&](const HttpData &, HttpData &response, ResponseControl &control) {
response = serverSideResponse;
responseControl = &control; // store for later
control.responseChunkSize = 5; // tell testserver to send data in chunks of this size