From 950123bfbc063998e6019d427d3dde600e7d51dd Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Thu, 28 Mar 2024 10:11:07 +0100 Subject: [PATCH] androiddeplyqt: fix missing pclose() on early return Found by Coverity. Amends 5bb178c479a247720fbc3fbb7f06a32b725193ac. Pick-to: 6.6 6.5 6.2 5.15 Coverity-Id: 378357 Change-Id: I8839280ce15d8e7d9e1f4024ca796c2d8b4ed930 Reviewed-by: BogDan Vatra (cherry picked from commit c64b30129d7c6c7f99b6abc3f42d32fb61e27f76) Reviewed-by: Qt Cherry-pick Bot --- src/tools/androiddeployqt/main.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/tools/androiddeployqt/main.cpp b/src/tools/androiddeployqt/main.cpp index 67193ac19cd..3fb2d0c7a92 100644 --- a/src/tools/androiddeployqt/main.cpp +++ b/src/tools/androiddeployqt/main.cpp @@ -2035,6 +2035,7 @@ QStringList getQtLibsFromElf(const Options &options, const QString &fileName) if (it == elfArchitectures.constEnd() || *it != options.currentArchitecture.toLatin1()) { if (options.verbose) fprintf(stdout, "Skipping \"%s\", architecture mismatch\n", qPrintable(fileName)); + pclose(readElfCommand); return {}; } }