From 94d9e05aa60b6b502c1606c485d72dcda24337b6 Mon Sep 17 00:00:00 2001
From: Ivan Solovev <ivan.solovev@qt.io>
Date: Mon, 28 Aug 2023 14:34:44 +0200
Subject: [PATCH] tst_QDnsLookup: extend test coverage for property bindings

The pre-existing tests were not using the QTestPrivate helpers, so
extend them with the call to QTestPrivate::testReadWritePropertyBasics.

The updated test didn't reveal any problems with binding loops, so no
other action is required for now.

Task-number: QTBUG-116346
Change-Id: I51a17974a7f5bec3c969fcb55b6f28e3e9218eb5
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
(cherry picked from commit 96a62cd1f5e5c5a915d60ba6d86a5ea44fc32acc)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
---
 .../network/kernel/qdnslookup/CMakeLists.txt  |  1 +
 .../kernel/qdnslookup/tst_qdnslookup.cpp      | 34 +++++++++++++++++++
 2 files changed, 35 insertions(+)

diff --git a/tests/auto/network/kernel/qdnslookup/CMakeLists.txt b/tests/auto/network/kernel/qdnslookup/CMakeLists.txt
index b069ba3ddc1..28f46b5bfd0 100644
--- a/tests/auto/network/kernel/qdnslookup/CMakeLists.txt
+++ b/tests/auto/network/kernel/qdnslookup/CMakeLists.txt
@@ -10,6 +10,7 @@ qt_internal_add_test(tst_qdnslookup
         tst_qdnslookup.cpp
     LIBRARIES
         Qt::Network
+        Qt::TestPrivate
 )
 
 qt_internal_extend_target(tst_qdnslookup CONDITION WIN32
diff --git a/tests/auto/network/kernel/qdnslookup/tst_qdnslookup.cpp b/tests/auto/network/kernel/qdnslookup/tst_qdnslookup.cpp
index 89d9063f8e4..f14f6f2c0e2 100644
--- a/tests/auto/network/kernel/qdnslookup/tst_qdnslookup.cpp
+++ b/tests/auto/network/kernel/qdnslookup/tst_qdnslookup.cpp
@@ -5,6 +5,7 @@
 
 #include <QTest>
 #include <QSignalSpy>
+#include <QtTest/private/qpropertytesthelper_p.h>
 
 #include <QtNetwork/QDnsLookup>
 
@@ -52,6 +53,7 @@ private slots:
     void setNameserver_data();
     void setNameserver();
     void bindingsAndProperties();
+    void automatedBindings();
 };
 
 static constexpr qsizetype HeaderSize = 6 * sizeof(quint16);
@@ -638,5 +640,37 @@ void tst_QDnsLookup::bindingsAndProperties()
     QCOMPARE(nameserverPortChangeSpy.size(), 1);
 }
 
+void tst_QDnsLookup::automatedBindings()
+{
+    QDnsLookup lookup;
+
+    QTestPrivate::testReadWritePropertyBasics(lookup, u"aaaa"_s, u"txt"_s, "name");
+    if (QTest::currentTestFailed()) {
+        qDebug("Failed property test for QDnsLookup::name");
+        return;
+    }
+
+    QTestPrivate::testReadWritePropertyBasics(lookup, QDnsLookup::AAAA, QDnsLookup::TXT, "type");
+    if (QTest::currentTestFailed()) {
+        qDebug("Failed property test for QDnsLookup::type");
+        return;
+    }
+
+    QTestPrivate::testReadWritePropertyBasics(lookup, QHostAddress{QHostAddress::Any},
+                                              QHostAddress{QHostAddress::LocalHost},
+                                              "nameserver");
+    if (QTest::currentTestFailed()) {
+        qDebug("Failed property test for QDnsLookup::nameserver");
+        return;
+    }
+
+    QTestPrivate::testReadWritePropertyBasics(lookup, quint16(123), quint16(456),
+                                              "nameserverPort");
+    if (QTest::currentTestFailed()) {
+        qDebug("Failed property test for QDnsLookup::nameserverPort");
+        return;
+    }
+}
+
 QTEST_MAIN(tst_QDnsLookup)
 #include "tst_qdnslookup.moc"