1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tst_QNetworkReply: fix mis-guided use of QSKIP().

Browse Source 
QSKIP() causes the whole test to be skipped, where this work-around
for a known quirk of the test server only requires skipping a single
Q_COMPARE(); the rest of the test passes fine without it.

Change-Id: Ie4612bd428f4cb4b342fad908cc2784fbadf069c
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
This commit is contained in:
Edward Welbourne 2016-03-15 15:50:37 +01:00
parent 51f040866b
commit 949aaffb4f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/auto/network/access/qnetworkreply/tst_qnetworkreply.cpp
View File

@ -6814,9 +6814,9 @@ void tst_QNetworkReply::authenticationCacheAfterCancel()
QTestEventLoop::instance().enterLoop(10); QTestEventLoop::instance().enterLoop(10);
QVERIFY(!QTestEventLoop::instance().timeout()); QVERIFY(!QTestEventLoop::instance().timeout());
if (reply->error() == QNetworkReply::HostNotFoundError) // Work round known quirk in the old test server:
QSKIP("skip because of quirk in the old test server"); if (reply->error() != QNetworkReply::HostNotFoundError)
QCOMPARE(reply->error(), QNetworkReply::ProxyAuthenticationRequiredError); QCOMPARE(reply->error(), QNetworkReply::ProxyAuthenticationRequiredError);
QCOMPARE(authSpy.count(), 0); QCOMPARE(authSpy.count(), 0);
QVERIFY(proxyAuthSpy.count() > 0); QVERIFY(proxyAuthSpy.count() > 0);
proxyAuthSpy.clear(); proxyAuthSpy.clear();