From 930dfd11dd7d8a0135c5d80d047b95bb8a55cbcd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A5rten=20Nordheim?= Date: Mon, 17 Feb 2025 15:55:24 +0100 Subject: [PATCH] Mark QHttpNetworkConnectionChannel as final To suppress clang-tidy's bugprone-pointer-arithmetic-on-polymorphic-object because we store a dynamically allocated array of QHttpNetworkConnectionChannel objects in QHttpNetworkConnectionPrivate and index into this all over the code. Pick-to: 6.9 6.8 Change-Id: Ibcdf7c8acc4a57eaf36bca3719733655053ac818 Reviewed-by: Marc Mutz Reviewed-by: Mate Barany --- src/network/access/qhttpnetworkconnectionchannel_p.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/access/qhttpnetworkconnectionchannel_p.h b/src/network/access/qhttpnetworkconnectionchannel_p.h index f8a54fceff5..e2a324fb5fd 100644 --- a/src/network/access/qhttpnetworkconnectionchannel_p.h +++ b/src/network/access/qhttpnetworkconnectionchannel_p.h @@ -62,7 +62,7 @@ class QByteArray; typedef std::pair HttpMessagePair; #endif -class QHttpNetworkConnectionChannel : public QObject { +class QHttpNetworkConnectionChannel final : public QObject { Q_OBJECT public: // TODO: Refactor this to add an EncryptingState (and remove pendingEncrypt).