diff --git a/src/widgets/dialogs/qcolordialog.cpp b/src/widgets/dialogs/qcolordialog.cpp index d31e54bc94a..c4917b65a27 100644 --- a/src/widgets/dialogs/qcolordialog.cpp +++ b/src/widgets/dialogs/qcolordialog.cpp @@ -2156,11 +2156,6 @@ void QColorDialog::setVisible(bool visible) void QColorDialogPrivate::setVisible(bool visible) { Q_Q(QColorDialog); - if (visible){ - if (q->testAttribute(Qt::WA_WState_ExplicitShowHide) && !q->testAttribute(Qt::WA_WState_Hidden)) - return; - } else if (q->testAttribute(Qt::WA_WState_ExplicitShowHide) && q->testAttribute(Qt::WA_WState_Hidden)) - return; if (visible) selectedQColor = QColor(); diff --git a/src/widgets/dialogs/qdialog.cpp b/src/widgets/dialogs/qdialog.cpp index a4c98139659..16730ed2c4e 100644 --- a/src/widgets/dialogs/qdialog.cpp +++ b/src/widgets/dialogs/qdialog.cpp @@ -740,6 +740,10 @@ void QDialog::closeEvent(QCloseEvent *e) void QDialog::setVisible(bool visible) { Q_D(QDialog); + + if (testAttribute(Qt::WA_WState_ExplicitShowHide) && testAttribute(Qt::WA_WState_Hidden) != visible) + return; + d->setVisible(visible); } @@ -764,9 +768,6 @@ void QDialogPrivate::setVisible(bool visible) } if (visible) { - if (q->testAttribute(Qt::WA_WState_ExplicitShowHide) && !q->testAttribute(Qt::WA_WState_Hidden)) - return; - q->QWidget::setVisible(visible); // Window activation might be prevented. We can't test isActiveWindow here, @@ -817,8 +818,6 @@ void QDialogPrivate::setVisible(bool visible) #endif } else { - if (q->testAttribute(Qt::WA_WState_ExplicitShowHide) && q->testAttribute(Qt::WA_WState_Hidden)) - return; #if QT_CONFIG(accessibility) if (q->isVisible()) { diff --git a/src/widgets/dialogs/qerrormessage.cpp b/src/widgets/dialogs/qerrormessage.cpp index 06b99bb296a..ed514809910 100644 --- a/src/widgets/dialogs/qerrormessage.cpp +++ b/src/widgets/dialogs/qerrormessage.cpp @@ -407,8 +407,6 @@ void QErrorMessage::showMessage(const QString &message, const QString &type) void QErrorMessagePrivate::setVisible(bool visible) { Q_Q(QErrorMessage); - if (q->testAttribute(Qt::WA_WState_ExplicitShowHide) && q->testAttribute(Qt::WA_WState_Hidden) != visible) - return; if (canBeNativeDialog()) setNativeDialogVisible(visible); diff --git a/src/widgets/dialogs/qfiledialog.cpp b/src/widgets/dialogs/qfiledialog.cpp index ad5bbf3ca6a..a947ee7d93a 100644 --- a/src/widgets/dialogs/qfiledialog.cpp +++ b/src/widgets/dialogs/qfiledialog.cpp @@ -848,11 +848,6 @@ void QFileDialog::setVisible(bool visible) void QFileDialogPrivate::setVisible(bool visible) { Q_Q(QFileDialog); - if (visible){ - if (q->testAttribute(Qt::WA_WState_ExplicitShowHide) && !q->testAttribute(Qt::WA_WState_Hidden)) - return; - } else if (q->testAttribute(Qt::WA_WState_ExplicitShowHide) && q->testAttribute(Qt::WA_WState_Hidden)) - return; if (canBeNativeDialog()){ if (setNativeDialogVisible(visible)){ diff --git a/src/widgets/dialogs/qfontdialog.cpp b/src/widgets/dialogs/qfontdialog.cpp index edea842def7..bb1619cb1fb 100644 --- a/src/widgets/dialogs/qfontdialog.cpp +++ b/src/widgets/dialogs/qfontdialog.cpp @@ -974,8 +974,7 @@ void QFontDialog::setVisible(bool visible) void QFontDialogPrivate::setVisible(bool visible) { Q_Q(QFontDialog); - if (q->testAttribute(Qt::WA_WState_ExplicitShowHide) && q->testAttribute(Qt::WA_WState_Hidden) != visible) - return; + if (canBeNativeDialog()) setNativeDialogVisible(visible); if (nativeDialogInUse) { diff --git a/src/widgets/dialogs/qmessagebox.cpp b/src/widgets/dialogs/qmessagebox.cpp index 2830d3f8ee2..bb71a2370e4 100644 --- a/src/widgets/dialogs/qmessagebox.cpp +++ b/src/widgets/dialogs/qmessagebox.cpp @@ -1660,8 +1660,6 @@ void QMessageBox::open(QObject *receiver, const char *member) void QMessageBoxPrivate::setVisible(bool visible) { Q_Q(QMessageBox); - if (q->testAttribute(Qt::WA_WState_ExplicitShowHide) && q->testAttribute(Qt::WA_WState_Hidden) != visible) - return; if (canBeNativeDialog()) setNativeDialogVisible(visible);