1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add comment to tst_QWidget::saveRestoreGeometry() for debugging

Browse Source 
saveRestoreGeometry() somtimes creates a 29px offset when debugged in
Qt Creator, which makes the test fail.

This patch adds a code comment to make developers aware of this fact.

Change-Id: I920bd02eb7543faf8b25a0a242b888f3a3745e2a
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
(cherry picked from commit efb74636567d9eff3366e439faf37eea5d6d3668)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Axel Spoerl 2022-11-01 10:44:33 +01:00 committed by Qt Cherry-pick Bot
parent 65b93df96a
commit 91bff47d31
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tests/auto/widgets/kernel/qwidget/tst_qwidget.cpp
View File

@ -4013,6 +4013,13 @@ void tst_QWidget::saveRestoreGeometry()
QVERIFY(QTest::qWaitForWindowExposed(&widget)); QVERIFY(QTest::qWaitForWindowExposed(&widget));
QApplication::processEvents(); QApplication::processEvents();
/* ---------------------------------------------------------------------
* This test function is likely to flake when debugged with Qt Creator.
* (29px offset making the following QTRY_VERIFY2 fail)
* ---------------------------------------------------------------------
*/
QTRY_VERIFY2(HighDpi::fuzzyCompare(widget.pos(), position, m_fuzz), QTRY_VERIFY2(HighDpi::fuzzyCompare(widget.pos(), position, m_fuzz),
qPrintable(HighDpi::msgPointMismatch(widget.pos(), position))); qPrintable(HighDpi::msgPointMismatch(widget.pos(), position)));
QCOMPARE(widget.size(), size); QCOMPARE(widget.size(), size);