From 8f22f242a2fcaad5adb9ce627dd6e61a1bfe220c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C4=99drzej=20Nowacki?= Date: Wed, 14 May 2014 14:35:21 +0200 Subject: [PATCH] Micro-optimize QUrl::topLevelDomain MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Using QStringRef saves few instructions Change-Id: I0d67a1f6a1c1385c88a8b21cb98b9c7dbdfb66e5 Reviewed-by: Oswald Buddenhagen Reviewed-by: Jędrzej Nowacki --- src/corelib/io/qtldurl.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/corelib/io/qtldurl.cpp b/src/corelib/io/qtldurl.cpp index dd4301e9f17..f8eddedf2fe 100644 --- a/src/corelib/io/qtldurl.cpp +++ b/src/corelib/io/qtldurl.cpp @@ -43,7 +43,8 @@ #include "qurl.h" #include "private/qurltlds_p.h" #include "private/qtldurl_p.h" -#include "QtCore/qstringlist.h" +#include "QtCore/qstring.h" +#include "QtCore/qvector.h" #include "QtCore/qhash.h" QT_BEGIN_NAMESPACE @@ -80,7 +81,8 @@ static bool containsTLDEntry(const QString &entry) Q_CORE_EXPORT QString qTopLevelDomain(const QString &domain) { - QStringList sections = domain.toLower().split(QLatin1Char('.'), QString::SkipEmptyParts); + const QString domainLower = domain.toLower(); + QVector sections = domainLower.splitRef(QLatin1Char('.'), QString::SkipEmptyParts); if (sections.isEmpty()) return QString();