1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rhi: Remove manual release of autoreleased NSString

Browse Source 
The [NSString stringWithUTF8String:] function returns an autoreleased
object, so we don't need to manually release it. Doing so results in
a crash when the surrounding autorelease pool is drained.

Change-Id: I3dca01e2771d4010e582c2bf770f3d2281343dc3
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
(cherry picked from commit 780813d9b6bfc58aa45571c367071c3a44fb2b44)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Tor Arne Vestbø 2023-01-25 22:38:25 +01:00 committed by Qt Cherry-pick Bot
parent 28c0af6dc3
commit 8eee5acfb2
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/gui/rhi/qrhimetal.mm
View File

@ -3724,10 +3724,7 @@ id<MTLLibrary> QRhiMetalData::createMetalLib(const QShader &shader, QShader::Var
id<MTLFunction> QRhiMetalData::createMSLShaderFunction(id<MTLLibrary> lib, const QByteArray &entryPoint) id<MTLFunction> QRhiMetalData::createMSLShaderFunction(id<MTLLibrary> lib, const QByteArray &entryPoint)
{ {
NSString *name = [NSString stringWithUTF8String: entryPoint.constData()]; return [lib newFunctionWithName:[NSString stringWithUTF8String:entryPoint.constData()]];
id<MTLFunction> f = [lib newFunctionWithName: name];
[name release];
return f;
} }
bool QMetalGraphicsPipeline::create() bool QMetalGraphicsPipeline::create()