From 8e3f04f54c421b2884b5c80bafc5d0df2212ffc1 Mon Sep 17 00:00:00 2001 From: Patryk Stachniak Date: Thu, 28 Nov 2024 09:14:49 +0100 Subject: [PATCH] Improve drag-and-drop visual handling in DragWidget Modified the mousePressEvent in DragWidget to temporarily detach the dragged QLabel from its parent using setParent(nullptr). This ensures the dragged widget remains visible and above other widgets during the drag operation. Re-parenting logic was added to restore the QLabel to its o riginal container if the drag action is not a MoveAction. This change addresses visual issues where dragged items could disappear behind overlapping widgets, enhancing user experience and maintaining consistent behavior. Task-number: QTBUG-123777 Pick-to: 6.6.2 Change-Id: I3edce9c96815e32eb8f00b61f7eda1709de04b4d Reviewed-by: Richard Moe Gustavsen --- .../draganddrop/draggableicons/dragwidget.cpp | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/examples/widgets/draganddrop/draggableicons/dragwidget.cpp b/examples/widgets/draganddrop/draggableicons/dragwidget.cpp index ba06c836d4d..2e3b71071a9 100644 --- a/examples/widgets/draganddrop/draggableicons/dragwidget.cpp +++ b/examples/widgets/draganddrop/draggableicons/dragwidget.cpp @@ -114,18 +114,13 @@ void DragWidget::mousePressEvent(QMouseEvent *event) drag->setHotSpot(event->position().toPoint() - child->pos()); //! [3] - QPixmap tempPixmap = pixmap; - QPainter painter; - painter.begin(&tempPixmap); - painter.fillRect(pixmap.rect(), QColor(127, 127, 127, 127)); - painter.end(); - - child->setPixmap(tempPixmap); + child->setParent(nullptr); if (drag->exec(Qt::CopyAction | Qt::MoveAction, Qt::CopyAction) == Qt::MoveAction) { - child->close(); + delete child; } else { + child->setParent(this); + child->move(event->position().toPoint() - drag->hotSpot()); child->show(); - child->setPixmap(pixmap); } }