From 8cbf402123285795a502b4dfafe24af799bb4887 Mon Sep 17 00:00:00 2001 From: Giuseppe D'Angelo Date: Thu, 18 Dec 2014 16:20:42 +0100 Subject: [PATCH] QComboBox: simplify code Remove an useless check and hoist a costly call out of a loop. Change-Id: Ibd1750026af44462a4f0223a9b2f422ebcc7c0e3 Reviewed-by: Olivier Goffart (Woboq GmbH) Reviewed-by: Gabriel de Dietrich --- src/widgets/widgets/qcombobox.cpp | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/widgets/widgets/qcombobox.cpp b/src/widgets/widgets/qcombobox.cpp index b38b482295d..24aef5254f3 100644 --- a/src/widgets/widgets/qcombobox.cpp +++ b/src/widgets/widgets/qcombobox.cpp @@ -1990,13 +1990,12 @@ void QComboBox::setModel(QAbstractItemModel *model) bool currentReset = false; - if (count()) { - for (int pos=0; pos < count(); pos++) { - if (d->model->index(pos, d->modelColumn, d->root).flags() & Qt::ItemIsEnabled) { - setCurrentIndex(pos); - currentReset = true; - break; - } + const int rowCount = count(); + for (int pos=0; pos < rowCount; pos++) { + if (d->model->index(pos, d->modelColumn, d->root).flags() & Qt::ItemIsEnabled) { + setCurrentIndex(pos); + currentReset = true; + break; } }