From 8bb365b0c57bef1267c8453176e3a34c7b7e54f9 Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Thu, 12 Jun 2025 06:53:22 -0700 Subject: [PATCH] tst_ContainerApiSymmetry: add non-deprecated copy assignment to Movable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Despite the name, this class is copyable, as evidenced by the fact it has a copy constructor. But that copy constructor causes the implicitly- declared copy-assignment operator to be deprecated. warning: implicitly-declared ‘constexpr Movable& Movable::operator=(const Movable&)’ is deprecated [-Wdeprecated-copy] tst_containerapisymmetry.cpp:55:5: note: because ‘Movable’ has user-provided ‘Movable::Movable(const Movable&)’ Amends 2e1763d83a1dacfc5b747934fb77fa7cec7bfe47 (5.14). Pick-to: 6.9 6.8 6.5 Change-Id: Ie661f7361a8d86648b21fffdaf9e7d076f86ebe9 Reviewed-by: Marc Mutz (cherry picked from commit 54069d37efa047de5ad7bdf1580720de61b9acd2) Reviewed-by: Qt Cherry-pick Bot --- .../tools/containerapisymmetry/tst_containerapisymmetry.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/auto/corelib/tools/containerapisymmetry/tst_containerapisymmetry.cpp b/tests/auto/corelib/tools/containerapisymmetry/tst_containerapisymmetry.cpp index 29b229637e3..c33ac53b13a 100644 --- a/tests/auto/corelib/tools/containerapisymmetry/tst_containerapisymmetry.cpp +++ b/tests/auto/corelib/tools/containerapisymmetry/tst_containerapisymmetry.cpp @@ -58,6 +58,8 @@ struct Movable ++instanceCount; } + Movable &operator=(const Movable &m) = default; + ~Movable() { --instanceCount;