QScopedValueRollback: make constructor explicit
I'm not even sure whether you could implicitly convert a T& into a QScopedValueRollback<T>, seeing as the constructor takes a non-const reference, but it looks wrong without explicit and QObject o = new QObject(parent); also won't compile even with implicit QObject(QObject*) under a conformant compiler because of the disabled copy constructor, and we still make QObject(QObject*) explicit, so add it here, too. Change-Id: I722a6e8431644e450fe2b401ccfb707a8e982380 Reviewed-by: Olivier Goffart <ogoffart@woboq.com> Reviewed-by: Lars Knoll <lars.knoll@nokia.com> Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
This commit is contained in:
parent
ec234625c0
commit
8b33be0054
@ -51,7 +51,7 @@ template <typename T>
|
|||||||
class QScopedValueRollback
|
class QScopedValueRollback
|
||||||
{
|
{
|
||||||
public:
|
public:
|
||||||
QScopedValueRollback(T &var) :
|
explicit QScopedValueRollback(T &var) :
|
||||||
varRef(var)
|
varRef(var)
|
||||||
{
|
{
|
||||||
oldValue = varRef;
|
oldValue = varRef;
|
||||||
|
Loading…
x
Reference in New Issue
Block a user