From 8735182dc6050e90ebc4af4beecca3614f5fdb26 Mon Sep 17 00:00:00 2001 From: Alexandru Croitor Date: Thu, 20 Jun 2024 18:25:29 +0200 Subject: [PATCH] CMake: Fix escaping in recording of provided targets In diff of below change, patch set 4 to 5, the list(APPEND) was replaced with a string(APPEND), but the escaping of semicolons was not removed. This caused an issue with packages that provide multiple targets when configuring qtsvg in a static qt build. Remove the unnecessary escaping. Amends 58eefbd0b6169d0749b312268c1ae1e594e04362 Change-Id: I1755f31b333e7cf76722cff490349bcc159d7e93 Reviewed-by: Joerg Bornemann (cherry picked from commit 9279a2f60e15ae02eb74f12db74a83cf3c1848d4) Reviewed-by: Qt Cherry-pick Bot --- cmake/QtPostProcessHelpers.cmake | 3 --- 1 file changed, 3 deletions(-) diff --git a/cmake/QtPostProcessHelpers.cmake b/cmake/QtPostProcessHelpers.cmake index 5cbee283b66..533236a2d40 100644 --- a/cmake/QtPostProcessHelpers.cmake +++ b/cmake/QtPostProcessHelpers.cmake @@ -105,9 +105,6 @@ function(qt_internal_collect_third_party_dep_packages_info get_cmake_property(provided_targets _qt_find_package_${package_key}_provided_targets) if(provided_targets) set(key "__qt_${target}_third_party_package_${package_key}_provided_targets") - - # Escape the semicolon, so it is preserved in the list(JOIN) below - string(REPLACE ";" "\;" provided_targets "${provided_targets}") string(APPEND packages_info "set(${key} \"${provided_targets}\")\n") endif() endforeach()