diff --git a/tests/auto/widgets/graphicsview/qgraphicsproxywidget/tst_qgraphicsproxywidget.cpp b/tests/auto/widgets/graphicsview/qgraphicsproxywidget/tst_qgraphicsproxywidget.cpp index 74d5fd20062..c01a80b0530 100644 --- a/tests/auto/widgets/graphicsview/qgraphicsproxywidget/tst_qgraphicsproxywidget.cpp +++ b/tests/auto/widgets/graphicsview/qgraphicsproxywidget/tst_qgraphicsproxywidget.cpp @@ -709,7 +709,7 @@ void tst_QGraphicsProxyWidget::focusNextPrevChild() QGraphicsScene scene; QGraphicsView view(&scene); view.show(); - QVERIFY(QTest::qWaitForWindowActive(&view)); + QVERIFY(QTest::qWaitForWindowFocused(&view)); if (hasScene) { scene.addItem(proxyGuard.release()); proxy->show(); @@ -984,7 +984,7 @@ void tst_QGraphicsProxyWidget::keyPressEvent() QGraphicsView view(&scene); view.show(); view.viewport()->setFocus(); - QVERIFY(QTest::qWaitForWindowActive(&view)); + QVERIFY(QTest::qWaitForWindowFocused(&view)); QCOMPARE(QApplication::activeWindow(), (QWidget*)&view); SubQGraphicsProxyWidget *proxy = new SubQGraphicsProxyWidget; @@ -1022,7 +1022,7 @@ void tst_QGraphicsProxyWidget::keyReleaseEvent() QGraphicsScene scene; QGraphicsView view(&scene); view.show(); - QVERIFY(QTest::qWaitForWindowActive(&view)); + QVERIFY(QTest::qWaitForWindowFocused(&view)); QCOMPARE(QApplication::activeWindow(), (QWidget*)&view); @@ -1067,7 +1067,7 @@ void tst_QGraphicsProxyWidget::mouseDoubleClickEvent() view.resize(100, 100); view.show(); - QVERIFY(QTest::qWaitForWindowActive(&view)); + QVERIFY(QTest::qWaitForWindowFocused(&view)); QCOMPARE(QApplication::activeWindow(), (QWidget*)&view); // wait for scene to be updated before doing any coordinate mappings on it QTRY_VERIFY(sceneChangedSpy.size() > 0); @@ -1152,7 +1152,7 @@ void tst_QGraphicsProxyWidget::paintEvent() QGraphicsScene scene; QGraphicsView view(&scene); view.show(); - QVERIFY(QTest::qWaitForWindowActive(&view)); + QVERIFY(QTest::qWaitForWindowFocused(&view)); QVERIFY(view.isActiveWindow()); SubQGraphicsProxyWidget proxy; @@ -1539,7 +1539,7 @@ void tst_QGraphicsProxyWidget::tabFocus_simpleWidget() window.show(); window.activateWindow(); - QVERIFY(QTest::qWaitForWindowActive(&window)); + QVERIFY(QTest::qWaitForWindowFocused(&window)); leftDial->setFocus(); QApplication::processEvents(); @@ -1622,7 +1622,7 @@ void tst_QGraphicsProxyWidget::tabFocus_simpleTwoWidgets() window.show(); window.activateWindow(); - QVERIFY(QTest::qWaitForWindowActive(&window)); + QVERIFY(QTest::qWaitForWindowFocused(&window)); leftDial->setFocus(); QApplication::processEvents(); @@ -1754,7 +1754,7 @@ void tst_QGraphicsProxyWidget::tabFocus_complexWidget() window.show(); window.activateWindow(); - QVERIFY(QTest::qWaitForWindowActive(&window)); + QVERIFY(QTest::qWaitForWindowFocused(&window)); leftDial->setFocus(); QApplication::processEvents(); @@ -1890,7 +1890,7 @@ void tst_QGraphicsProxyWidget::tabFocus_complexTwoWidgets() window.show(); window.activateWindow(); - QVERIFY(QTest::qWaitForWindowActive(&window)); + QVERIFY(QTest::qWaitForWindowFocused(&window)); leftDial->setFocus(); QApplication::processEvents(); @@ -2063,7 +2063,7 @@ void tst_QGraphicsProxyWidget::setFocus_simpleWidget() window.show(); window.activateWindow(); - QVERIFY(QTest::qWaitForWindowActive(&window)); + QVERIFY(QTest::qWaitForWindowFocused(&window)); QCOMPARE(QApplication::activeWindow(), &window); leftDial->setFocus(); @@ -2134,7 +2134,7 @@ void tst_QGraphicsProxyWidget::setFocus_simpleTwoWidgets() window.show(); window.activateWindow(); - QVERIFY(QTest::qWaitForWindowActive(&window)); + QVERIFY(QTest::qWaitForWindowFocused(&window)); QCOMPARE(QApplication::activeWindow(), &window); leftDial->setFocus(); @@ -2212,7 +2212,7 @@ void tst_QGraphicsProxyWidget::setFocus_complexTwoWidgets() window.show(); window.activateWindow(); - QVERIFY(QTest::qWaitForWindowActive(&window)); + QVERIFY(QTest::qWaitForWindowFocused(&window)); QCOMPARE(QApplication::activeWindow(), &window); leftDial->setFocus(); @@ -3333,7 +3333,7 @@ void tst_QGraphicsProxyWidget::clickFocus() view.setFrameStyle(0); view.resize(300, 300); view.show(); - QVERIFY(QTest::qWaitForWindowActive(&view)); + QVERIFY(QTest::qWaitForWindowFocused(&view)); QVERIFY(!proxy->hasFocus()); QVERIFY(!proxy->widget()->hasFocus()); diff --git a/tests/auto/widgets/graphicsview/qgraphicsscene/tst_qgraphicsscene.cpp b/tests/auto/widgets/graphicsview/qgraphicsscene/tst_qgraphicsscene.cpp index 515ba80bbe2..0f5882bf6a5 100644 --- a/tests/auto/widgets/graphicsview/qgraphicsscene/tst_qgraphicsscene.cpp +++ b/tests/auto/widgets/graphicsview/qgraphicsscene/tst_qgraphicsscene.cpp @@ -3041,7 +3041,7 @@ void tst_QGraphicsScene::tabFocus_emptyScene() widget.setWindowTitle(QTest::currentTestFunction()); widget.show(); widget.activateWindow(); - QVERIFY(QTest::qWaitForWindowActive(&widget)); + QVERIFY(QTest::qWaitForWindowFocused(&widget)); dial1->setFocus(); QVERIFY(dial1->hasFocus()); @@ -4807,7 +4807,7 @@ void tst_QGraphicsScene::focusOnTouch() rect->setFlag(QGraphicsItem::ItemIsFocusable, true); view.show(); - QVERIFY(QTest::qWaitForWindowActive(&view)); + QVERIFY(QTest::qWaitForWindowFocused(&view)); QVERIFY(!rect->hasFocus()); @@ -4907,7 +4907,7 @@ void tst_QGraphicsScene::taskQTBUG_16401_focusItem() rect->setFlag(QGraphicsItem::ItemIsFocusable); view.show(); - QVERIFY(QTest::qWaitForWindowActive(&view)); + QVERIFY(QTest::qWaitForWindowFocused(&view)); QVERIFY(!scene.focusItem()); diff --git a/tests/auto/widgets/graphicsview/qgraphicsview/tst_qgraphicsview.cpp b/tests/auto/widgets/graphicsview/qgraphicsview/tst_qgraphicsview.cpp index ed99cd93a8f..7599afd6e0d 100644 --- a/tests/auto/widgets/graphicsview/qgraphicsview/tst_qgraphicsview.cpp +++ b/tests/auto/widgets/graphicsview/qgraphicsview/tst_qgraphicsview.cpp @@ -2159,7 +2159,7 @@ void tst_QGraphicsView::sendEvent() QGraphicsView view(&scene); view.show(); QVERIFY(QTest::qWaitForWindowExposed(&view)); - QVERIFY(QTest::qWaitForWindowActive(&view)); + QVERIFY(QTest::qWaitForWindowFocused(&view)); QCOMPARE(QApplication::activeWindow(), static_cast(&view)); item->setFocus(); @@ -2226,7 +2226,7 @@ void tst_QGraphicsView::wheelEvent() QGraphicsView view(&scene); view.show(); QVERIFY(QTest::qWaitForWindowExposed(&view)); - QVERIFY(QTest::qWaitForWindowActive(&view)); + QVERIFY(QTest::qWaitForWindowFocused(&view)); QCOMPARE(QApplication::activeWindow(), static_cast(&view)); @@ -3191,7 +3191,7 @@ void tst_QGraphicsView::task172231_untransformableItems() view.scale(2, 1); view.show(); QVERIFY(QTest::qWaitForWindowExposed(&view)); - QVERIFY(QTest::qWaitForWindowActive(&view)); + QVERIFY(QTest::qWaitForWindowFocused(&view)); QCOMPARE(QApplication::activeWindow(), static_cast(&view)); QRectF origExposedRect = text->exposedRect; @@ -4402,7 +4402,7 @@ void tst_QGraphicsView::inputMethodSensitivity() QGraphicsView view(&scene); view.show(); QVERIFY(QTest::qWaitForWindowExposed(&view)); - QVERIFY(QTest::qWaitForWindowActive(&view)); + QVERIFY(QTest::qWaitForWindowFocused(&view)); QCOMPARE(QApplication::activeWindow(), static_cast(&view)); FocusItem *item = new FocusItem; @@ -4999,7 +4999,7 @@ void tst_QGraphicsView::QTBUG_53974_mismatched_hide_show_events() topLevel.show(); topLevel.activateWindow(); - QVERIFY(QTest::qWaitForWindowActive(&topLevel)); + QVERIFY(QTest::qWaitForWindowFocused(&topLevel)); // Starting point QCOMPARE_EQ(topLevel.currentIndex(), 0); diff --git a/tests/auto/widgets/graphicsview/qgraphicswidget/tst_qgraphicswidget.cpp b/tests/auto/widgets/graphicsview/qgraphicswidget/tst_qgraphicswidget.cpp index 9fd93ca91d7..a97acbac82e 100644 --- a/tests/auto/widgets/graphicsview/qgraphicswidget/tst_qgraphicswidget.cpp +++ b/tests/auto/widgets/graphicsview/qgraphicswidget/tst_qgraphicswidget.cpp @@ -1459,7 +1459,7 @@ void tst_QGraphicsWidget::setTabOrderAndReparent() QGraphicsScene scene; QGraphicsView view(&scene); view.show(); - QVERIFY(QTest::qWaitForWindowActive(&view)); + QVERIFY(QTest::qWaitForWindowFocused(&view)); QCOMPARE(QApplication::activeWindow(), (QWidget*)&view); QGraphicsWidget *w[4]; @@ -1588,7 +1588,7 @@ void tst_QGraphicsWidget::verifyFocusChain() QGraphicsScene scene; QGraphicsView view(&scene); view.show(); - QVERIFY(QTest::qWaitForWindowActive(&view)); + QVERIFY(QTest::qWaitForWindowFocused(&view)); { // parent/child focus diff --git a/tests/auto/widgets/itemviews/qabstractitemview/tst_qabstractitemview.cpp b/tests/auto/widgets/itemviews/qabstractitemview/tst_qabstractitemview.cpp index 2cbb1279581..2b93e5685c7 100644 --- a/tests/auto/widgets/itemviews/qabstractitemview/tst_qabstractitemview.cpp +++ b/tests/auto/widgets/itemviews/qabstractitemview/tst_qabstractitemview.cpp @@ -1854,7 +1854,7 @@ void tst_QAbstractItemView::QTBUG31411_noSelection() moveCursorAway(&window); window.show(); - QVERIFY(QTest::qWaitForWindowActive(&window)); + QVERIFY(QTest::qWaitForWindowFocused(&window)); qRegisterMetaType(); QSignalSpy selectionChangeSpy(table->selectionModel(), &QItemSelectionModel::selectionChanged); diff --git a/tests/auto/widgets/itemviews/qheaderview/tst_qheaderview.cpp b/tests/auto/widgets/itemviews/qheaderview/tst_qheaderview.cpp index 57efa3e3496..095060d3fc6 100644 --- a/tests/auto/widgets/itemviews/qheaderview/tst_qheaderview.cpp +++ b/tests/auto/widgets/itemviews/qheaderview/tst_qheaderview.cpp @@ -3382,7 +3382,7 @@ void tst_QHeaderView::stretchAndRestoreLastSection() const int someOtherSectionSize = 40; const int biggerSizeThanAnySection = 50; - QVERIFY(QTest::qWaitForWindowActive(&tv)); + QVERIFY(QTest::qWaitForWindowFocused(&tv)); QHeaderView &header = *tv.horizontalHeader(); // set minimum size before resizeSections() is called diff --git a/tests/auto/widgets/kernel/qapplication/tst_qapplication.cpp b/tests/auto/widgets/kernel/qapplication/tst_qapplication.cpp index 31edaee981e..d5bbf502888 100644 --- a/tests/auto/widgets/kernel/qapplication/tst_qapplication.cpp +++ b/tests/auto/widgets/kernel/qapplication/tst_qapplication.cpp @@ -1624,7 +1624,7 @@ void tst_QApplication::focusWidget() QTextEdit te; te.show(); - QVERIFY(QTest::qWaitForWindowActive(&te)); + QVERIFY(QTest::qWaitForWindowFocused(&te)); const auto focusWidget = QApplication::focusWidget(); QVERIFY(focusWidget); @@ -1639,7 +1639,7 @@ void tst_QApplication::focusWidget() QTextEdit te(&w); w.show(); - QVERIFY(QTest::qWaitForWindowActive(&w)); + QVERIFY(QTest::qWaitForWindowFocused(&w)); const auto focusWidget = QApplication::focusWidget(); QVERIFY(focusWidget); diff --git a/tests/auto/widgets/widgets/qbuttongroup/tst_qbuttongroup.cpp b/tests/auto/widgets/widgets/qbuttongroup/tst_qbuttongroup.cpp index 3ff748ef27a..566f4ed52ce 100644 --- a/tests/auto/widgets/widgets/qbuttongroup/tst_qbuttongroup.cpp +++ b/tests/auto/widgets/widgets/qbuttongroup/tst_qbuttongroup.cpp @@ -203,8 +203,7 @@ void tst_QButtonGroup::keyNavigationPushButtons() buttonGroup->addButton(pb3); dlg.show(); - if (!QTest::qWaitForWindowActive(&dlg)) - QSKIP("Window activation failed, skipping test"); + QVERIFY(QTest::qWaitForWindowFocused(&dlg)); QVERIFY2(le1->hasFocus(), qPrintable(qApp->focusWidget()->objectName())); QTest::keyClick(qApp->focusWidget(), Qt::Key_Tab); diff --git a/tests/auto/widgets/widgets/qdatetimeedit/tst_qdatetimeedit.cpp b/tests/auto/widgets/widgets/qdatetimeedit/tst_qdatetimeedit.cpp index 2d9689db415..f3d6d9c78c1 100644 --- a/tests/auto/widgets/widgets/qdatetimeedit/tst_qdatetimeedit.cpp +++ b/tests/auto/widgets/widgets/qdatetimeedit/tst_qdatetimeedit.cpp @@ -1347,8 +1347,7 @@ void tst_QDateTimeEdit::editingRanged() }); edit->show(); - if (!QTest::qWaitForWindowActive(edit.get())) - QSKIP("Failed to make window active, aborting"); + QVERIFY(QTest::qWaitForWindowFocused(edit.get())); edit->setFocus(); // with keyboard tracking, never get a signal with an out-of-range value diff --git a/tests/auto/widgets/widgets/qmenu/tst_qmenu.cpp b/tests/auto/widgets/widgets/qmenu/tst_qmenu.cpp index 57cc404fc74..18808cce160 100644 --- a/tests/auto/widgets/widgets/qmenu/tst_qmenu.cpp +++ b/tests/auto/widgets/widgets/qmenu/tst_qmenu.cpp @@ -1613,7 +1613,7 @@ void tst_QMenu::transientParent() QVERIFY(topLevel); window.setFocus(); - QVERIFY(QTest::qWaitForWindowActive(&window)); + QVERIFY(QTest::qWaitForWindowFocused(&window)); QVERIFY(window.hasFocus()); QTest::keyPress(&window, Qt::Key_F, Qt::AltModifier);