1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QXmlStreamWriter: don't call virtual QTextCodec::name() twice

Browse Source 
Just cache and reuse result.

Change-Id: I2ada2eced7c272c041013d35b59eeb176ed04659
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
This commit is contained in:
Anton Kudryavtsev 2016-06-02 14:28:34 +03:00
parent 3b3ca5dead
commit 86b612d037
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/corelib/xml/qxmlstream.cpp
View File

@ -3790,7 +3790,8 @@ void QXmlStreamWriter::writeStartDocument(const QString &version)
#ifdef QT_NO_TEXTCODEC
d->write("iso-8859-1");
#else
d->write(d->codec->name().constData(), d->codec->name().length());
const QByteArray name = d->codec->name();
d->write(name.constData(), name.length());
#endif
}
d->write("\"?>");
@ -3813,7 +3814,8 @@ void QXmlStreamWriter::writeStartDocument(const QString &version, bool standalon
#ifdef QT_NO_TEXTCODEC
d->write("iso-8859-1");
#else
d->write(d->codec->name().constData(), d->codec->name().length());
const QByteArray name = d->codec->name();
d->write(name.constData(), name.length());
#endif
}
if (standalone)