1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

macOS: Document firstRectForCharacterRange:actualRange

Browse Source 
And add a note about the missing logic for when the range is non-zero.

Change-Id: I31e8ab55afa022aa4d72c3f23920b3f5beba9fc6
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
(cherry picked from commit 9f326390d91a7c721770d0f8bf7ed88c7fe72d20)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Tor Arne Vestbø 2024-10-11 17:55:40 +02:00 committed by Qt Cherry-pick Bot
parent bc83fb11a1
commit 868e5de059
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/platforms/cocoa/qnsview_complextext.mm
View File

@ -484,6 +484,18 @@
}
}
/*
Returns the first logical boundary rectangle for characters in the given range,
in screen coordinates.
The "first" in the name refers to the rectangle enclosing the first line when
the range encompasses multiple lines of text. In that case, actualRange should
be set to the range covered by the first rect, so all line fragments can
be queried by invoking this method repeatedly.
If the length of range is 0 (as it would be if there is nothing selected at
the insertion point), then the rectangle coincides with the insertion point.
*/
- (NSRect)firstRectForCharacterRange:(NSRange)range actualRange:(NSRangePointer)actualRange
{
Q_UNUSED(range);
@ -491,6 +503,8 @@
QWindow *window = m_platformWindow ? m_platformWindow->window() : nullptr;
if (window && queryInputMethod(window->focusObject())) {
if (range.length) // FIXME: Handle the case when range is non-zero
qCWarning(lcQpaKeys) << "Can't satisfy firstRectForCharacterRange for" << range;
QRect cursorRect = qApp->inputMethod()->cursorRectangle().toRect();
cursorRect.moveBottomLeft(window->mapToGlobal(cursorRect.bottomLeft()));
return QCocoaScreen::mapToNative(cursorRect);