1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add some comments to clarify meaning of observers in property system

Browse Source 
It took me quite a while to figure out that two objects with
a similar type and a similar name which occur side by side have
a quite different meaning. Add a comment for the next one.

Change-Id: Idf4d63d8ed09ead2c3d82a798e6d7476024209bf
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
This commit is contained in:
Andreas Buhr 2020-12-18 12:15:21 +01:00
parent 096b4590d5
commit 855a0433a5
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/corelib/kernel/qproperty_p.h
View File

@ -184,10 +184,10 @@ private:
QtPrivate::QPropertyObserverCallback staticObserverCallback = nullptr;
QtPrivate::QPropertyBindingWrapper staticBindingWrapper;
};
ObserverArray inlineDependencyObservers;
ObserverArray inlineDependencyObservers; // for things we are observing
QPropertyObserverPointer firstObserver;
QScopedPointer<std::vector<QPropertyObserver>> heapObservers;
QPropertyObserverPointer firstObserver; // list of observers observing us
QScopedPointer<std::vector<QPropertyObserver>> heapObservers; // for things we are observing
QUntypedPropertyData *propertyDataPtr = nullptr;