1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qFindChar: pass char16_t by value

Browse Source 
Cheaply-copied types should be passed by value
according to https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-in

Change-Id: I341193c0a65931c1406fc7d711ef74d763178dee
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Anton Kudryavtsev 2023-10-02 18:59:26 +03:00
parent 3d631da88b
commit 8419b56097
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/corelib/text/qstring.cpp
View File

@ -150,7 +150,7 @@ static inline qsizetype qFindChar(QStringView str, QChar ch, qsizetype from, Qt:
return n - s; return n - s;
} else { } else {
c = foldCase(c); c = foldCase(c);
auto it = std::find_if(n, e, [c](const auto &ch) { return foldAndCompare(ch, c); }); auto it = std::find_if(n, e, [c](auto ch) { return foldAndCompare(ch, c); });
if (it != e) if (it != e)
return std::distance(s, it); return std::distance(s, it);
} }