From 82a9ecb1753a018d0b178f440b515aa3c0a2d723 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20Wierci=C5=84ski?= Date: Thu, 19 Oct 2023 13:04:14 +0200 Subject: [PATCH] wasm: Fix UB in QEventDispatcher Calling std::mutex::try_lock() when the mutex is already owned by the thread casuses undefined behavior. Change-Id: I024ced271cad8a034bebf80b48e31e7e7461c560 Reviewed-by: Giuseppe D'Angelo --- src/corelib/kernel/qeventdispatcher_wasm.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/corelib/kernel/qeventdispatcher_wasm.cpp b/src/corelib/kernel/qeventdispatcher_wasm.cpp index fd618580f5d..930ff068712 100644 --- a/src/corelib/kernel/qeventdispatcher_wasm.cpp +++ b/src/corelib/kernel/qeventdispatcher_wasm.cpp @@ -271,7 +271,6 @@ bool QEventDispatcherWasm::isValidEventDispatcherPointer(QEventDispatcherWasm *e if (eventDispatcher == g_mainThreadEventDispatcher) return true; #if QT_CONFIG(thread) - Q_ASSERT(!g_staticDataMutex.try_lock()); // caller must lock mutex if (g_secondaryThreadEventDispatchers.contains(eventDispatcher)) return true; #endif