1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QNetworkInfo[NetworkManager]: Fix double-lookup

Browse Source 
Change-Id: Ia44993fa229b223cfa40ed6cf922c4d5cfd3042b
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Mate Barany <mate.barany@qt.io>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
This commit is contained in:
Mårten Nordheim 2023-09-25 16:52:02 +02:00
parent 14510bac9a
commit 8111a7d08f
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/networkinformation/networkmanager/qnetworkmanagerservice.cpp
View File

@ -92,17 +92,17 @@ QNetworkManagerInterface::~QNetworkManagerInterface()
QNetworkManagerInterface::NMState QNetworkManagerInterface::state() const QNetworkManagerInterface::NMState QNetworkManagerInterface::state() const
{ {
if (propertyMap.contains(stateKey())) { auto it = propertyMap.constFind(stateKey());
return static_cast<QNetworkManagerInterface::NMState>(propertyMap.value(stateKey()) if (it != propertyMap.cend())
.toUInt()); return static_cast<QNetworkManagerInterface::NMState>(it->toUInt());
}
return QNetworkManagerInterface::NM_STATE_UNKNOWN; return QNetworkManagerInterface::NM_STATE_UNKNOWN;
} }
QNetworkManagerInterface::NMConnectivityState QNetworkManagerInterface::connectivityState() const QNetworkManagerInterface::NMConnectivityState QNetworkManagerInterface::connectivityState() const
{ {
if (propertyMap.contains(connectivityKey())) auto it = propertyMap.constFind(connectivityKey());
return static_cast<NMConnectivityState>(propertyMap.value(connectivityKey()).toUInt()); if (it != propertyMap.cend())
return static_cast<NMConnectivityState>(it->toUInt());
return QNetworkManagerInterface::NM_CONNECTIVITY_UNKNOWN; return QNetworkManagerInterface::NM_CONNECTIVITY_UNKNOWN;
} }