From 7f807cdd423366901890e26cff0b6b2d9496fd98 Mon Sep 17 00:00:00 2001
From: Volker Hilsheimer <volker.hilsheimer@qt.io>
Date: Fri, 9 Jun 2023 23:41:36 +0200
Subject: [PATCH] QMetaCallEvent::create: pass arguments by const ref

Amends 4d7ae8a74e70896a757f483865fe7095120fedc1.

Change-Id: Id4379324c2399f2360b3553d297f38dd793af21c
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
(cherry picked from commit 38a00d2c978eba90e9006418de5ebaf89092b079)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
---
 src/corelib/kernel/qobject_p.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/corelib/kernel/qobject_p.h b/src/corelib/kernel/qobject_p.h
index de014a5525a..4b757b2bd93 100644
--- a/src/corelib/kernel/qobject_p.h
+++ b/src/corelib/kernel/qobject_p.h
@@ -389,14 +389,14 @@ public:
 
     template<typename ...Args>
     static QMetaCallEvent *create(QtPrivate::QSlotObjectBase *slotObj, const QObject *sender,
-                                  int signal_index, Args ...argv)
+                                  int signal_index, const Args &...argv)
     {
         auto metaCallEvent = std::make_unique<QMetaCallEvent>(slotObj, sender,
                                                               signal_index, int(1 + sizeof...(Args)));
 
         void **args = metaCallEvent->args();
         QMetaType *types = metaCallEvent->types();
-        const std::array<void *, sizeof...(Args) + 1> argp{ nullptr, std::addressof(argv)... };
+        const std::array<const void *, sizeof...(Args) + 1> argp{ nullptr, std::addressof(argv)... };
         const std::array metaTypes{ QMetaType::fromType<void>(), QMetaType::fromType<Args>()... };
         for (size_t i = 0; i < sizeof...(Args) + 1; ++i) {
             types[i] = metaTypes[i];