1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Benchlib: remove unused init() virtual function

Browse Source 
Commit 051f68c2d3a069543dce4d560facff6aa22284bd (Qt 5.2) made it empty
by moving the content to QBenchmarkPerfEventsMeasurer::start().

Change-Id: I65f48d72a9d079f0aee5fffd6abeae9cf7fcdcf5
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
(cherry picked from commit d44b3ad1c8f1e6615e47c4d62b236c57f051b709)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Thiago Macieira 2024-09-19 17:03:13 -07:00 committed by Qt Cherry-pick Bot
parent 8101f3366a
commit 7d858ad28c
4 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/testlib/qbenchmark.cpp
View File

@ -55,7 +55,6 @@ QBenchmarkMeasurerBase * QBenchmarkGlobalData::createMeasurer()
} else { } else {
measurer = new QBenchmarkTimeMeasurer; measurer = new QBenchmarkTimeMeasurer;
} }
measurer->init();
return measurer; return measurer;
} }

1
src/testlib/qbenchmarkmeasurement_p.h
View File

@ -30,7 +30,6 @@ public:
QTest::QBenchmarkMetric metric; QTest::QBenchmarkMetric metric;
}; };
virtual ~QBenchmarkMeasurerBase() = default; virtual ~QBenchmarkMeasurerBase() = default;
virtual void init() {}
virtual void start() = 0; virtual void start() = 0;
virtual QList<Measurement> stop() = 0; virtual QList<Measurement> stop() = 0;
virtual bool isMeasurementAccepted(Measurement m) = 0; virtual bool isMeasurementAccepted(Measurement m) = 0;

4
src/testlib/qbenchmarkperfevents.cpp
View File

@ -448,10 +448,6 @@ QBenchmarkPerfEventsMeasurer::~QBenchmarkPerfEventsMeasurer()
qt_safe_close(fd); qt_safe_close(fd);
} }
void QBenchmarkPerfEventsMeasurer::init()
{
}
void QBenchmarkPerfEventsMeasurer::start() void QBenchmarkPerfEventsMeasurer::start()
{ {
QT_WARNING_DISABLE_GCC("-Wmissing-field-initializers") QT_WARNING_DISABLE_GCC("-Wmissing-field-initializers")

1
src/testlib/qbenchmarkperfevents_p.h
View File

@ -24,7 +24,6 @@ class QBenchmarkPerfEventsMeasurer : public QBenchmarkMeasurerBase
public: public:
QBenchmarkPerfEventsMeasurer(); QBenchmarkPerfEventsMeasurer();
~QBenchmarkPerfEventsMeasurer(); ~QBenchmarkPerfEventsMeasurer();
void init() override;
void start() override; void start() override;
QList<Measurement> stop() override; QList<Measurement> stop() override;
bool isMeasurementAccepted(Measurement measurement) override; bool isMeasurementAccepted(Measurement measurement) override;