1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tst_QScroller::overshoot(): improve diagnostic output, blacklist on mac

Browse Source 
Test is flaky on macOS.
Use QCOMPARE_LT instead of QVERIFY(a < b).
Blacklist on macOS.

Task-number: QTBUG-134105
Pick-to: 6.9 6.8
Change-Id: I8f1274ad67bd9ead392ecd0f9c9b7a01dc3edb1e
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
This commit is contained in:
Axel Spoerl 2025-02-26 14:48:37 +01:00
parent 1719379471
commit 7c7731a822
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/auto/widgets/util/qscroller/BLACKLIST
View File

@ -6,3 +6,6 @@ macos
# QTBUG-87409
[scrollTo]
android
[overshoot]
macos

2
tests/auto/widgets/util/qscroller/tst_qscroller.cpp
View File

@ -488,7 +488,7 @@ void tst_QScroller::overshoot()
QScrollerPrivate* priv = s1->d_func();
QVERIFY(priv->xSegments.size() == 1);
auto& segment = priv->xSegments.head();
QVERIFY(segment.startPos + segment.deltaPos < segment.stopPos);
QCOMPARE_LT(segment.startPos + segment.deltaPos, segment.stopPos);
QTRY_COMPARE(s1->state(), QScroller::Inactive);