From 7c332839e0e90b32cc0b590b5de945af8a1c4c6c Mon Sep 17 00:00:00 2001 From: Ivan Solovev Date: Fri, 13 Dec 2024 18:01:30 +0100 Subject: [PATCH] Specify an underlying type for QCommandLineParser::MessageType And also add a trailing comma to the last element of the enum to minimize future diffs. Amends bad618606d64e943e3fa78e7d1dbc8e1fab55480. Found in Qt 6.9 API review. Change-Id: I1a30c344967005c9abc73e59980e56626e09cd7c Reviewed-by: David Faure Reviewed-by: Thiago Macieira (cherry picked from commit 14cc2591ac06dbcee01c2b110e014db2993d7a1e) Reviewed-by: Qt Cherry-pick Bot --- src/corelib/tools/qcommandlineparser.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/corelib/tools/qcommandlineparser.h b/src/corelib/tools/qcommandlineparser.h index 05308c1fe93..a15c2604fb6 100644 --- a/src/corelib/tools/qcommandlineparser.h +++ b/src/corelib/tools/qcommandlineparser.h @@ -67,9 +67,9 @@ public: Q_NORETURN void showHelp(int exitCode = 0); QString helpText() const; - enum MessageType { + enum MessageType : quint32 { InformationMessage, - ErrorMessage + ErrorMessage, }; Q_NORETURN static void showMessageAndExit(const QString &message, MessageType type, int exitCode = 0);