1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QString: remove unnecessary copy in replace()

Browse Source 
When a copy is needed, replace_helper() takes
care of that for us.

Change-Id: I9e5c89cb70b2902c96062a9edaf77fedda6ddb2c
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
This commit is contained in:
Anton Kudryavtsev 2016-03-30 13:19:03 +03:00
parent cd21da3922
commit 7a4ce3cbcc
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/corelib/tools/qstring.cpp
View File

@ -2346,8 +2346,7 @@ QString &QString::remove(QChar ch, Qt::CaseSensitivity cs)
*/ */
QString &QString::replace(int pos, int len, const QString &after) QString &QString::replace(int pos, int len, const QString &after)
{ {
QString copy = after; return replace(pos, len, after.constData(), after.length());
return replace(pos, len, copy.constData(), copy.length());
} }
/*! /*!