From 7955dceec1fe093a1d29de58590e08be4e68ccfa Mon Sep 17 00:00:00 2001 From: Volker Hilsheimer Date: Fri, 14 Jan 2022 00:20:56 +0100 Subject: [PATCH] Fix warning on macOS builds, unbreak -developer-build The mix of signed (qsizetype) and unsigned long when comparing breaks local -Werror,-Wsign-compare builds. Amends d83dbc3db2f305e745cd75a9fd9c97128eaac42f. Change-Id: I7910b7e2dfaaa01d8069ce52e97c0166e6d3fa30 Reviewed-by: Timur Pocheptsov Reviewed-by: Edward Welbourne --- src/corelib/text/qcollator_macx.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/corelib/text/qcollator_macx.cpp b/src/corelib/text/qcollator_macx.cpp index 713df755007..8adc640fa7b 100644 --- a/src/corelib/text/qcollator_macx.cpp +++ b/src/corelib/text/qcollator_macx.cpp @@ -138,7 +138,7 @@ QCollatorSortKey QCollator::sortKey(const QString &string) const status = UCGetCollationKey(d->collator, text, string.count(), ret.size(), &actualSize, ret.data()); Q_ASSERT(status != kUCOutputBufferTooSmall); - Q_ASSERT(ret.size() == actualSize + 1); + Q_ASSERT(ret.size() == qsizetype(actualSize + 1)); } ret[actualSize] = 0; return QCollatorSortKey(new QCollatorSortKeyPrivate(std::move(ret)));